lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luc Vanlerberghe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENENET-493) Make lucene.net culture insensitive (like the java version)
Date Mon, 18 Jun 2012 11:26:43 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13395818#comment-13395818
] 

Luc Vanlerberghe commented on LUCENENET-493:
--------------------------------------------

Perhaps my comment was not sufficiently clear:
I didn't solve a problem in the testcases, I solved a problem in Lucene.Net itself
I happened to stumble upon the problem because I executed the tests in a non-US locale.

The java version tests if Lucene behaves independently of the culture.
Even if we can't duplicate the way this is tested, we should still make sure Lucene.net behaves
independently of the culture too.

When the patch is applied, as a side-effect, the tests also pass when run in another culture.

                
> Make lucene.net culture insensitive (like the java version)
> -----------------------------------------------------------
>
>                 Key: LUCENENET-493
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-493
>             Project: Lucene.Net
>          Issue Type: Bug
>          Components: Lucene.Net Core, Lucene.Net Test
>    Affects Versions: Lucene.Net 3.0.3
>            Reporter: Luc Vanlerberghe
>              Labels: patch
>             Fix For: Lucene.Net 3.0.3
>
>         Attachments: Lucenenet-493.patch
>
>
> In Java, conversion of the basic types to and from strings is locale (culture) independent.
For localized input/output one needs to use the classes in the java.text package.
> In .Net, conversion of the basic types to and from strings depends on the default Culture.
 Otherwise you have to specify CultureInfo.InvariantCulture explicitly.
> Some of the testcases in lucene.net fail if they are not run on a machine with culture
set to US.
> In the current version of lucene.net there are patches here and there that try to correct
for some specific cases by using string replacement (like  System.Double.Parse(s.Replace(".",
CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator)), but that seems really ugly.
> I submit a patch here that removes the old workarounds and replaces them by calls to
classes in the Lucene.Net.Support namespace that try to handle the conversions in a compatible
way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message