lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Itamar Syn-Hershko <ita...@code972.com>
Subject Re: Spatial contrib bug fixing
Date Mon, 23 Apr 2012 08:19:51 GMT
One more thing - what's the deal with ChainedFilter? I can see a commit by
DIGY on 7/7/2011 but it seems to have been removed since?

On Mon, Apr 23, 2012 at 11:06 AM, Itamar Syn-Hershko <itamar@code972.com>wrote:

> For starters - CartesianPolyFilterBuilder.GetBoxShape() is not an exact
> port - do you remember why?
>
> Anyway, if it was never fully ported as you say maybe I'll just go ahead
> and complete that
>
> For your reference, here are 2 failing tests which pass in Java Lucene
> (can send the java file) -
> https://github.com/synhershko/lucene.net/commit/234da7eca7cb08be5a0c2a7375ffc3f4a03bfd92
>
>
>
> On Mon, Apr 23, 2012 at 1:39 AM, Prescott Nasser <geobmx540@hotmail.com>wrote:
>
>>
>> I think that was a while ago, and I don't even recall if I fully ported
>> it or just put up the start. I had some other stuff to deal with the last
>> few months, so my memory is a bit lacking. I'll review the code, meanwhile
>> ask whatever questions you have - lets get this fixed up. ~P
>>  > Date: Sun, 22 Apr 2012 22:10:27 +0300
>> > Subject: Spatial contrib bug fixing
>> > From: itamar@code972.com
>> > To: lucene-net-dev@lucene.apache.org
>> >
>> > Hi all,
>> >
>> > We encountered several bugs with the Sparial contrb, and the ones we
>> tested
>> > with Java Lucene worked there (with 2.9.4). There are about 3 open
>> tickets
>> > in the Jira bug tracker on similar issues.
>> >
>> > I'm now sitting with the ultimate goal of fixing this once and for all,
>> but
>> > some code parts are commented out in favor of other not line-by-line
>> port
>> > of some implementations, without a comment giving reasons. I was
>> wondering
>> > if there's anyone who could answer a few questions there, instead of me
>> > changing things back and forth?
>> >
>> > Git history (I use the Git mirror, yes) tells me Prescott Nasser is
>> behind
>> > porting this - maybe he will have the answers?
>> >
>> > Cheers,
>> >
>> > Itamar.
>>
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message