lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Currens (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [Lucene.Net] [jira] [Issue Comment Edited] (LUCENENET-451) Missing License Headers in trunk
Date Tue, 01 Nov 2011 21:43:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141637#comment-13141637
] 

Christopher Currens edited comment on LUCENENET-451 at 11/1/11 9:43 PM:
------------------------------------------------------------------------

I'm reopening this because the addition of the headers in the solution files cause the solutions
files to not be recognized by Visual Studio 2010, where the express solutions could before
be imported.  (This may affect Visual C# Express edition as well).

The header comments for these files are currently being placed at the beginning of the file.
 Instead, they should be put after the following two lines in the lucene solution and each
of the contrib and test solutions:

{code:xml}
Microsoft Visual Studio Solution File, Format Version 11.00
# Visual C# Express 2010
{code}

I can make a fix and push to trunk shortly, but I will also upload another patch for the other
branches.
                
      was (Author: ccurrens):
    I'm reopening this because the addition of the headers in the solution files cause the
solutions files to not be recognized by Visual Studio 2010, where the express solutions could
before be imported.  (This may affect Visual C# Express edition as well).

The header comments for these files are currently being placed at the beginning of the file.
 Instead, they should be put after the following two lines in the lucene solution and each
of the contrib and test solutions:

{quote}
Microsoft Visual Studio Solution File, Format Version 11.00
# Visual C# Express 2010
{quote}

I can make a fix and push to trunk shortly, but I will also upload another patch for the other
branches.
                  
> Missing License Headers in trunk
> --------------------------------
>
>                 Key: LUCENENET-451
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-451
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Stefan Bodewig
>            Assignee: Christopher Currens
>             Fix For: Lucene.Net 2.9.4
>
>         Attachments: LUCENENET-451.trunk.patch
>
>
> Many files lack the ASF license headers, I'll attach a patch against trunk shortly.
> I can provide patches against branches as well if this seems easier than merging from
trunk.
> So far I have deliberately skipped the docs and lib directories as docs seems to contain
generated files only and the lib folder is something that needs to be talked about separately
anyway.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message