lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stuart Robinson (JIRA)" <j...@apache.org>
Subject [Lucene.Net] [jira] [Created] (LUCENENET-443) SpellChecker finaliser calls close regardless of if closed already
Date Thu, 15 Sep 2011 10:54:08 GMT
SpellChecker finaliser calls close regardless of if closed already
------------------------------------------------------------------

                 Key: LUCENENET-443
                 URL: https://issues.apache.org/jira/browse/LUCENENET-443
             Project: Lucene.Net
          Issue Type: Improvement
          Components: Lucene.Net Contrib
    Affects Versions: Lucene.Net 2.9.2
            Reporter: Stuart Robinson


The SpellChecker Class currently has no publicly visible way of accessing the closed field.
It also calls close in the finaliser killing the process it is in upon GC as this can throw
an exceptin. I propose two changes:

Change the already existing method "IsClosed()" to public:
        public bool IsClosed()
        {
            return closed;
        }

and add a check on this in the finaliser:
        ~SpellChecker()
        {
            if (!IsClosed())
                this.Close();
        }

Ideally this class should implement IDisposable but I think this would be a bigger job than
this two line change.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message