lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Digy (JIRA)" <j...@apache.org>
Subject [Lucene.Net] [jira] [Commented] (LUCENENET-426) Mark BaseFragmentsBuilder methods as virtual
Date Wed, 22 Jun 2011 22:56:47 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053519#comment-13053519
] 

Digy commented on LUCENENET-426:
--------------------------------

Perhaps you do something wrong
Since you posted in your blog as
{quote}
Perhaps you have tackled this before: you wanted to use Lucene's FastVectorHighlighter (aka
FVH), but since you have a custom CharFilter in your analysis chain, the highlighter fails
to produce valid fragments.
{quote}
which is definitely wrong.

DIGY

> Mark BaseFragmentsBuilder methods as virtual
> --------------------------------------------
>
>                 Key: LUCENENET-426
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-426
>             Project: Lucene.Net
>          Issue Type: Improvement
>          Components: Lucene.Net Contrib
>    Affects Versions: Lucene.Net 2.9.2, Lucene.Net 2.9.4, Lucene.Net 3.x, Lucene.Net 2.9.4g
>            Reporter: Itamar Syn-Hershko
>            Priority: Minor
>             Fix For: Lucene.Net 2.9.4, Lucene.Net 2.9.4g
>
>         Attachments: fvh.patch
>
>
> Without marking methods in BaseFragmentsBuilder as virtual, it is meaningless to have
FragmentsBuilder deriving from a class named "Base", since most of its functionality cannot
be overridden. Attached is a patch for marking the important methods virtual.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message