lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Digy (JIRA)" <j...@apache.org>
Subject [Lucene.Net] [jira] [Commented] (LUCENENET-422) Custom tokenizers may fail when indexing due to ReusableStringReader not implement some method of TextReader
Date Sun, 05 Jun 2011 13:37:47 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044524#comment-13044524
] 

Digy commented on LUCENENET-422:
--------------------------------

percyboy,

Thanks for your bug fix.
I commited the fix to trunk(2.9.4) & to 2.9.4g branch.

PS: None of the TextReader's methods like ReadBlock, ReadLine, Peek, ReadToEnd were implemented
in ReusableStringReader.
And calling these methods returned only empty strings without giving any info to the users.
Therefore I added these NotImplementedExceptions in LUCENENET-150 and implemented just ReadToEnd
(the only method I used in my custom analyzer).




DIGY



> Custom tokenizers may fail when indexing due to ReusableStringReader not implement some
method of TextReader
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENENET-422
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-422
>             Project: Lucene.Net
>          Issue Type: Bug
>          Components: Lucene.Net Core
>    Affects Versions: Lucene.Net 2.9.2
>         Environment: from Lucene 2.3.x to current trunk
>            Reporter: percyboy
>             Fix For: Lucene.Net 2.9.4, Lucene.Net 2.9.4g
>
>         Attachments: ReusableStringReader.cs
>
>
> Lucene.Net.Index.ReusableStringReader is inherited from TextReader, but marks some methods
as Not Implemented.
> Some custom tokenizers who call these unfinished methods will meet an error.
> It is, somewhat, like a trap.
> LUCENENET-150 is a similar issue to this one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message