lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andy Pook <andy.p...@gmail.com>
Subject Re: [Lucene.Net] [jira] [Commented] (LUCENENET-412) Replacing ArrayLists, Hashtables etc. with appropriate Generics.
Date Fri, 20 May 2011 09:34:54 GMT
It'd be useful if There was a StopAnalyzer ctor overload that took an
IEnumerable<string> and maybe the current one that takes List<string> should
be ICollection<string> (same as internal stopWords member).
Just gives a little flexibility on the types that can be used.

Also there is a little confusion around the treatment of the various
collection types. i.e. string[] gets converted to  a CharArraySet. Why not
just a List<string> ?

Thoughts?

Cheers,
  Andy

On 18 May 2011 23:20, Digy (JIRA) <jira@apache.org> wrote:

>
>    [
> https://issues.apache.org/jira/browse/LUCENENET-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035795#comment-13035795]
>
> Digy commented on LUCENENET-412:
> --------------------------------
>
> Hi All,
>
> Lucene.Net 2.9.4g is almost ready for testing & feedbacks.
>
> While injecting generics & making some clean up in code, I tried to be
> close to lucene 3.0.3 as much as possible.
> Therefore it's position is somewhere between lucene.Java 2.9.4 & 3.0.3
>
> DIGY
>
>
> PS: For those who might want to try this version:
> It won't probably be a drop-in replacement since there are a few API
> changes like
> - StopAnalyzer(List<string> stopWords)
> - Query.ExtractTerms(ICollection<string>)
> - TopDocs.*TotalHits*, TopDocs.*ScoreDocs*
> and some removed methods/classes like
> - Filter.Bits
> - JustCompileSearch
> - Contrib/Similarity.Net
>
>
>
>
> > Replacing ArrayLists, Hashtables etc. with appropriate Generics.
> > ----------------------------------------------------------------
> >
> >                 Key: LUCENENET-412
> >                 URL: https://issues.apache.org/jira/browse/LUCENENET-412
> >             Project: Lucene.Net
> >          Issue Type: Improvement
> >    Affects Versions: Lucene.Net 2.9.4
> >            Reporter: Digy
> >            Priority: Minor
> >             Fix For: Lucene.Net 2.9.4
> >
> >         Attachments: IEquatable for Query&Subclasses.patch,
> LUCENENET-412.patch, lucene_2.9.4g_exceptions_fix
> >
> >
> > This will move Lucene.Net.2.9.4 closer to lucene.3.0.3 and allow some
> performance gains.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message