lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicholas Paldino (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENENET-314) Excluded files from project
Date Tue, 01 Dec 2009 05:12:20 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784061#action_12784061
] 

Nicholas Paldino commented on LUCENENET-314:
--------------------------------------------

I can't say that this is a good idea.

There are files in this list (if not all) that are abstract, and also concrete implementations
of types.

There could be those that are relying on those types (or base abstract types) and removing
them would create an issue.

If they are no longer used, and they aren't affecting the compile state of the project (or
the tests passing), I say keep them in the project and attach the Obsolete attribute:

http://msdn.microsoft.com/en-us/library/system.obsoleteattribute.aspx

The description should indicate why the class is obsolete as well as a suggested replacement
(if possible/applicable), and for this specific case, tell which version of Lucene.NET the
class was made obsolete in.

Then, it will show up as a warning when end-users compile it.

> Excluded files from project
> ---------------------------
>
>                 Key: LUCENENET-314
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-314
>             Project: Lucene.Net
>          Issue Type: Improvement
>            Reporter: Digy
>            Priority: Minor
>
> Creating this issue on behalf of  Eran Sevi
> DIGY
> {quote}
> Hi,
> There are many files that are maintained in the svn but are not included in the Lucene.Net
csproj.
> Probably these files are leftovers from previous releases since the project compiles
and runs without a problem. If not, they should be included in the project.
> I think we should include a patch that removes all these files.
> Here's the list of the files I found that are not used:
> Index\DirectoryIndexReader.cs
> Index\MultiSegmentReader.cs
> Index\ReadOnlyMultiSegmentReader.cs
> Index\StoredFieldsWriterPerField.cs
> Index\StoredFieldWriterPerThread.cs
> Search\ExtendedFieldCacheImpl.cs
> Search\NonMatchingScorer.cs
> Search\RemoteCachingWrapperFilter.cs
> Search\RemoteSearchable.cs
> Search\Spans\NearSpans.cs
> Search\Spans\PayloadSpans.cs
> Thanks,
> Eran.
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message