lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Aroush (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENENET-325) public fields starting with lowercase letter( TopDocs.totalHits and TopDocs.scoreDocs )
Date Mon, 14 Dec 2009 03:44:18 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789974#action_12789974
] 

George Aroush commented on LUCENENET-325:
-----------------------------------------

Hi DIGY,

I'm really concerned about this change.  Did you script to achieve this?  If so, can the script
revert this change?

I have two key concerns with this change:
1) This change will cause a lot of "false" noise when I generate a delta for the next release.
 My hope was to save such work for 3.0.
2) This change will render almost all code under contrib unusable.

Another side effect of this change is existing clients of older version of Lucene.Net, who
will migrate to 2.9.1, will now have to do more work to adopt 2.9.1.

The reason why I asked if this change can be reverted is manly to see if I can do so before
when porting 3.0 to reduce the "false" noise.

Thanks.

-- George


> public fields starting with lowercase letter( TopDocs.totalHits and  TopDocs.scoreDocs
)
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENENET-325
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-325
>             Project: Lucene.Net
>          Issue Type: Bug
>         Environment: 2.9.1
>            Reporter: Digy
>            Priority: Trivial
>         Attachments: LUCENENET-325.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message