lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Aroush (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENENET-206) TestToken + Tokenattributes (2.9.0)
Date Sun, 08 Nov 2009 13:22:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774771#action_12774771
] 

George Aroush commented on LUCENENET-206:
-----------------------------------------

Looks good.  Commit away.

But first, please cleanup left over commented code:

+            FlagsAttributeImpl impl = new FlagsAttributeImpl();
+            impl.flags = this.flags;
+            return impl;
+            //System.Diagnostics.Debug.Fail("Port issue:", "Let see if we need this FlagsAttributeImpl.Clone()");
// {{Aroush-2.9}}
+			//return null;

There is no point to keep the commented diagnostics code (there are couple of them in this
patch).

Thanks!

> TestToken + Tokenattributes (2.9.0)
> -----------------------------------
>
>                 Key: LUCENENET-206
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-206
>             Project: Lucene.Net
>          Issue Type: Bug
>         Environment: 2.9.0
>            Reporter: Digy
>            Priority: Minor
>         Attachments: LUCENENET-206.patch
>
>
> mostly bugs in "Clone"s and  Assert.AreNotSame <> Assert.AreNotEqual

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message