lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Garski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENENET-210) FSDirectory - DirectoryInfo vs. FileInfo
Date Mon, 09 Nov 2009 15:14:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774997#action_12774997
] 

Michael Garski commented on LUCENENET-210:
------------------------------------------

I'll separate the the changes and create a patch with these changes isolated.  They fix the
failing tests in TestDirectory.

I don't see this as an API change, but an API correction.  I believe the automated portion
of the porting replaces Java's File class with FileInfo in all cases, however with regards
to Lucene it results in an incorrect usage that results in an excessive amount of internal
inefficiencies to accommodate the input of a FileInfo object. 

I'll detail more of the changes and provide more of my view on this later this morning.




> FSDirectory - DirectoryInfo vs. FileInfo
> ----------------------------------------
>
>                 Key: LUCENENET-210
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-210
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Michael Garski
>         Attachments: FSDirectory_di_vs_fi.patch
>
>
> From what I know of the Java File class, it can represent a file or a directory, whereas
in .NET the explicit classes FileInfo and DirectoryInfo would apply.  I've altered the usage
of the two different classes depending on what the purpose is, be it a directory or a file.
 This does change the interface to instantiation of classes such as IndexReader with a DirectoryInfo
object as opposed to a FileInfo object which is more precise and actually cleans up the internals
a bit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message