lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Aroush (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENENET-210) FSDirectory - DirectoryInfo vs. FileInfo
Date Fri, 13 Nov 2009 20:30:39 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777639#action_12777639
] 

George Aroush commented on LUCENENET-210:
-----------------------------------------

Committed.  Thanks Mike!

Two points:

1) Your patch, for some reason didn't include changes required to Lucene.Net.Store.TestLockFactory.TestNativeFSLockFactoryPrefix().
 Nothing major, just to let you know In case the patch isn't being properly generated.

2) I kept both GetFile() and GetDirectory().  I'm going to open a discussion with the Java
Lucene folks and see if they are willing to add a GetDirectory() in their 3.0 so that the
APIs can be 1-to-1.

> FSDirectory - DirectoryInfo vs. FileInfo
> ----------------------------------------
>
>                 Key: LUCENENET-210
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-210
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Michael Garski
>         Attachments: FSDirectory V2.patch
>
>
> From what I know of the Java File class, it can represent a file or a directory, whereas
in .NET the explicit classes FileInfo and DirectoryInfo would apply.  I've altered the usage
of the two different classes depending on what the purpose is, be it a directory or a file.
 This does change the interface to instantiation of classes such as IndexReader with a DirectoryInfo
object as opposed to a FileInfo object which is more precise and actually cleans up the internals
a bit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message