lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Aroush (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENENET-210) FSDirectory - DirectoryInfo vs. FileInfo
Date Mon, 09 Nov 2009 12:38:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774949#action_12774949
] 

George Aroush commented on LUCENENET-210:
-----------------------------------------

I almost forgot.  Please do not combine 2 or more patches into one.  This makes it hard to
review a patch, makes testing a patch harder, and very difficult to rollback a patch.

> FSDirectory - DirectoryInfo vs. FileInfo
> ----------------------------------------
>
>                 Key: LUCENENET-210
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-210
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Michael Garski
>         Attachments: FSDirectory_di_vs_fi.patch
>
>
> From what I know of the Java File class, it can represent a file or a directory, whereas
in .NET the explicit classes FileInfo and DirectoryInfo would apply.  I've altered the usage
of the two different classes depending on what the purpose is, be it a directory or a file.
 This does change the interface to instantiation of classes such as IndexReader with a DirectoryInfo
object as opposed to a FileInfo object which is more precise and actually cleans up the internals
a bit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message