lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Aroush (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENENET-59) QueryUtils has some invalid Asserts
Date Tue, 14 Aug 2007 19:59:31 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519757
] 

George Aroush commented on LUCENENET-59:
----------------------------------------

Hi Jeff,

I'm not comfortable with this patch.

For example, you changed:

    Assert.AreEqual(q1.GetHashCode(), q2.GetHashCode());

To:

    Assert.AreEqual(q1.ToString(), q2.ToString());

The intention of this test is to verify that the generated hash value is consistent for those
two queries.  The fact that this test is failing tells us the hash values are not constant
and thus, we have a defect somewhere in Lucene.Net with the way we are creating hash values.
 The fix has to be in Lucene.Net code and not in the Test code.

Let me know if I'm overlooking something.

Regards,

-- George

> QueryUtils has some invalid Asserts
> -----------------------------------
>
>                 Key: LUCENENET-59
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-59
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Jeff
>            Priority: Minor
>         Attachments: QueryUtils.patch, QueryUtils.patch2
>
>
> NUnit tests are failing because of bad Asserts in CheckEqual(Query q1, Query q2) and
CheckUnequal(Query q1, Query q2).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message