lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Aroush (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENENET-86) Nunit test for TestSort.
Date Thu, 23 Aug 2007 15:56:30 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522180
] 

George Aroush commented on LUCENENET-86:
----------------------------------------

Hi Digy,

I too grabbed a fresh copy from SVN and re-run this sub-test, with and without the patch and
the test will pass in both cases.

What local are you on?  Is it possible this is more of an issue with parsing ".", vs. ","?
 Also, in the call stack that you provided, what line in the file FieldDocSortedHitQueue.cs
is the exception of type InvalidCastException occurring?

My concern with this patch is that it is adding new logic to the Lucene.Net code which will
diverge it from the Java version.  In addition, I have not been able to understand the defect
the patch is trying to solve, and that I can't reproduce it.

Regards,

-- George

> Nunit test for TestSort.
> ------------------------
>
>                 Key: LUCENENET-86
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-86
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Digy
>            Priority: Minor
>         Attachments: FieldDocSortedHitQueue.patch, Screenshot.JPG
>
>
> There are two bugs in FieldDocSortedHitQueue.LessThan method
> 1-  in  "case SortField.FLOAT:"
>      The  value of   docA.fields[i] or docB.fields[i] may be a string. In this case SupportClass.Single.Parse
should be invoked.
> 2- No null control for docA.fields[i] or docB.fields[i].

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message