logging-log4cxx-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shuvalov, Andrew V" <Andrew.Shuva...@gs.com>
Subject RE: Class xxx has virtual functions but non-virtual destructor
Date Tue, 11 May 2004 20:50:16 GMT
Actually dispite huge amount of warnings, the fix is only 2 lines long (2
classes have to be fixed):
 
diff
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers//class.h
/u/shuvaa/local/log4cxx-0.9.7/include/log4cxx/helpers//class.h
56d55
<                     virtual ~Class () {}
Only in
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/: class.h~
diff
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers//dateformat.h
/u/shuvaa/local/log4cxx-0.9.7/include/log4cxx/helpers//dateformat.h
36d35
<                         virtual ~DateFormat () {}


-----Original Message-----
From: Shuvalov, Andrew V 
Sent: Tuesday, May 11, 2004 4:41 PM
To: 'Log4CXX User'
Subject: Class xxx has virtual functions but non-virtual destructor




Actually the problem is that when I put this into my company's project, I'm
getting each warning 50 times, once per project file :-(((  

50 time like this: 


/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/class.h:53: warning: ` 
   class log4cxx::helpers::Class' has virtual functions but non-virtual 
   destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/s
pi/appenderattachable.h:23,

                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/appenderattachableimpl.h:20,

                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/l
ogger.h:22, 
                 from MatrixLog.hh:228, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/object.h:85: warning: ` 
   class log4cxx::helpers::Object::ClassObject' has virtual functions but 
   non-virtual destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/a
ppender.h:24, 
                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/s
pi/appenderattachable.h:24,

                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/appenderattachableimpl.h:20,

                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/l
ogger.h:22, 
                 from MatrixLog.hh:228, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/s
pi/optionhandler.h:37: warning: ` 
   class log4cxx::spi::OptionHandler::ClassOptionHandler' has virtual
functions 
   but non-virtual destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/s
pi/appenderattachable.h:24,

                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/appenderattachableimpl.h:20,

                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/l
ogger.h:22, 
                 from MatrixLog.hh:228, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/a
ppender.h:56: warning: ` 
   class log4cxx::Appender::ClassAppender' has virtual functions but 
   non-virtual destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/appenderattachableimpl.h:20,

                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/l
ogger.h:22, 
                 from MatrixLog.hh:228, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/s
pi/appenderattachable.h:45: warning: ` 
   class log4cxx::spi::AppenderAttachable::ClassAppenderAttachable' has
virtual 
   functions but non-virtual destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/l
ogger.h:22, 
                 from MatrixLog.hh:228, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/appenderattachableimpl.h:46: warning: `

   class
log4cxx::helpers::AppenderAttachableImpl::ClassAppenderAttachableImpl' 
   has virtual functions but non-virtual destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/l
ogger.h:24, 
                 from MatrixLog.hh:228, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/l
evel.h:57: warning: ` 
   class log4cxx::Level::LevelClass' has virtual functions but non-virtual 
   destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/l
ogger.h:25, 
                 from MatrixLog.hh:228, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/s
pi/loggerfactory.h:38: warning: ` 
   class log4cxx::spi::LoggerFactory::ClassLoggerFactory' has virtual
functions 
   but non-virtual destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/l
ogger.h:26, 
                 from MatrixLog.hh:228, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/s
pi/loggerrepository.h:63: warning: ` 
   class log4cxx::spi::LoggerRepository::ClassLoggerRepository' has virtual 
   functions but non-virtual destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/l
ogger.h:27, 
                 from MatrixLog.hh:228, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/resourcebundle.h:42: warning: ` 
   class log4cxx::helpers::ResourceBundle::ClassResourceBundle' has virtual 
   functions but non-virtual destructor 
In file included from MatrixLog.hh:228, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/l
ogger.h:56: warning: ` 
   class log4cxx::Logger::ClassLogger' has virtual functions but non-virtual

   destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/a
ppenderskeleton.h:21, 
                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/w
riterappender.h:20, 
                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/c
onsoleappender.h:20, 
                 from MatrixLog.hh:229, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/l
ayout.h:43: warning: ` 
   class log4cxx::Layout::ClassLayout' has virtual functions but non-virtual

   destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/a
ppenderskeleton.h:22, 
                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/w
riterappender.h:20, 
                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/c
onsoleappender.h:20, 
                 from MatrixLog.hh:229, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/s
pi/errorhandler.h:71: warning: ` 
   class log4cxx::spi::ErrorHandler::ClassErrorHandler' has virtual
functions 
   but non-virtual destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/a
ppenderskeleton.h:23, 
                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/w
riterappender.h:20, 
                 from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/c
onsoleappender.h:20, 
                 from MatrixLog.hh:229, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/s
pi/filter.h:73: warning: ` 
   class log4cxx::spi::Filter::ClassFilter' has virtual functions but 
   non-virtual destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/c
onsoleappender.h:20, 
                 from MatrixLog.hh:229, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/w
riterappender.h:64: warning: ` 
   class log4cxx::WriterAppender::ClassWriterAppender' has virtual functions

   but non-virtual destructor 
In file included from MatrixLog.hh:229, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/c
onsoleappender.h:35: warning: ` 
   class log4cxx::ConsoleAppender::ClassConsoleAppender' has virtual
functions 
   but non-virtual destructor 
In file included from MatrixLog.hh:232, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/s
pi/loggingevent.h:61: warning: ` 
   class log4cxx::spi::LoggingEvent::ClassLoggingEvent' has virtual
functions 
   but non-virtual destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/dateformat.h:21,

                 from MatrixLog.hh:233, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/timezone.h:36: warning: ` 
   class log4cxx::helpers::TimeZone::ClassTimeZone' has virtual functions
but 
   non-virtual destructor 
In file included from MatrixLog.hh:233, 
                 from MatrixLog.cc:5: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/dateformat.h:32: warning: ` 
   class log4cxx::helpers::DateFormat' has virtual functions but non-virtual

   destructor 
In file included from MatrixLog.cc:6: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
ierarchy.h:85: warning: ` 
   class log4cxx::Hierarchy::ClassHierarchy' has virtual functions but 
   non-virtual destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/p
atternlayout.h:21, 
                 from MatrixLog.cc:7: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/patternconverter.h:50: warning: ` 
   class log4cxx::helpers::PatternConverter::ClassPatternConverter' has
virtual 
   functions but non-virtual destructor 
In file included from MatrixLog.cc:7: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/p
atternlayout.h:399: warning: ` 
   class log4cxx::PatternLayout::ClassPatternLayout' has virtual functions
but 
   non-virtual destructor 
In file included from MatrixLog.cc:8: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/s
implelayout.h:42: warning: ` 
   class log4cxx::SimpleLayout::ClassSimpleLayout' has virtual functions but

   non-virtual destructor 
In file included from
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
tmllayout.h:21, 
                 from MatrixLog.cc:9: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
elpers/iso8601dateformat.h:36: warning: ` 
   class log4cxx::helpers::ISO8601DateFormat' has virtual functions but 
   non-virtual destructor 
In file included from MatrixLog.cc:9: 
/ny/blasto/Prel/REPO/ASFlog/DELIV/sun-sparc-SunOS5.8/0.9.7/include/log4cxx/h
tmllayout.h:59: warning: ` 
   class log4cxx::HTMLLayout::ClassHTMLLayout' has virtual functions but 
   non-virtual destructor 


Mime
View raw message