logging-log4cxx-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michaël CATANZARITI <mca...@free.fr>
Subject Re: Class xxx has virtual functions but non-virtual destructor
Date Fri, 07 May 2004 04:35:30 GMT

I didn't get this warning on Linux or Windows.

In C++, a virtual destructor is mandatory only if you call delete on a 
pointer to a parent class of the class to delete.
in log4cxx case, the classes Class, ClassObject, ClassAppender, ... are 
instanciated as global/static variables (cf. macro 
DECLARE_LOG4CXX_OBJECT). Therefor I think there is no problem !


Christian Sailer wrote:

> Shuvalov, Andrew V wrote:
>> This warning happens quite many times in the code. Please fix in many 
>> classes, like
>> Class, ClassObject, ..., ClassLoggerRepository, ..., 
>> ClassConsoleAppender
> I was already wondering wether this is just a mistake or if there is a 
> reason for this behavior. Could you tell me, Michael?
> If it's just the keyword "virtual" missing in a few places, I could 
> fix it and submit a patch...
> Christian

View raw message