From commits-return-14691-apmail-kafka-commits-archive=kafka.apache.org@kafka.apache.org Wed Jun 3 20:43:58 2020 Return-Path: X-Original-To: apmail-kafka-commits-archive@www.apache.org Delivered-To: apmail-kafka-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id B67731947F for ; Wed, 3 Jun 2020 20:43:57 +0000 (UTC) Received: (qmail 99849 invoked by uid 500); 3 Jun 2020 20:43:56 -0000 Delivered-To: apmail-kafka-commits-archive@kafka.apache.org Received: (qmail 99818 invoked by uid 500); 3 Jun 2020 20:43:56 -0000 Mailing-List: contact commits-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list commits@kafka.apache.org Received: (qmail 99809 invoked by uid 99); 3 Jun 2020 20:43:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jun 2020 20:43:56 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 8372F814A0; Wed, 3 Jun 2020 20:43:56 +0000 (UTC) Date: Wed, 03 Jun 2020 20:43:51 +0000 To: "commits@kafka.apache.org" Subject: [kafka] 01/02: MINOR: Upgrade spotbugs and spotbugsPlugin (#8790) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: ijuma@apache.org In-Reply-To: <159121702644.15718.1354263787564678177@gitbox.apache.org> References: <159121702644.15718.1354263787564678177@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: kafka X-Git-Refname: refs/heads/2.6 X-Git-Reftype: branch X-Git-Rev: 91f9c2652f5833817f826690b70fc597de9bc223 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20200603204356.8372F814A0@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. ijuma pushed a commit to branch 2.6 in repository https://gitbox.apache.org/repos/asf/kafka.git commit 91f9c2652f5833817f826690b70fc597de9bc223 Author: showuon <43372967+showuon@users.noreply.github.com> AuthorDate: Thu Jun 4 04:17:31 2020 +0800 MINOR: Upgrade spotbugs and spotbugsPlugin (#8790) Upgrade spotbugsPlugin to have clear output indicating where the error is. When investigating KAFKA-10081, I found the error output of spotbugs is very poor. It doesn't even tell you where the error is and how many errors found, it will take a lot of time for the developers to find out where the error is, and then fix it. ![image](https://user-images.githubusercontent.com/43372967/83590263-efc42a80-a587-11ea-95cf-e9097d9a662e.png) https://builds.apache.org/blue/organizations/jenkins/kafka-trunk-jdk8/detail/kafka-trunk-jdk8/4596/pipeline/ Then, I found out there's a bug in spotbugsPlugin in V4.0.x, and got fixed in V4.2.x https://github.com/spotbugs/spotbugs-gradle-plugin/issues/210 So, after upgrading to V4.2.x (I followed to the latest version V4.2.4), the output is like this: ![image](https://user-images.githubusercontent.com/43372967/83590913-60b81200-a589-11ea-9a04-1449d693c2f2.png) So you know there's 1 error and you can also open the report file to find out the error. Upgraded to the latest bug fix release of spotbugs (4.0.3) while at it. Reviewers: Ismael Juma --- gradle/dependencies.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle index 294d0c4..d803f1c 100644 --- a/gradle/dependencies.gradle +++ b/gradle/dependencies.gradle @@ -111,8 +111,8 @@ versions += [ shadowPlugin: "5.2.0", slf4j: "1.7.30", snappy: "1.1.7.3", - spotbugs: "4.0.2", - spotbugsPlugin: "4.0.5", + spotbugs: "4.0.3", + spotbugsPlugin: "4.2.4", spotlessPlugin: "3.28.1", testRetryPlugin: "1.1.5", zinc: "1.3.5",