kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [kafka] branch trunk updated: MINOR: Fix fetch session epoch comment in `FetchRequest.json` (#8802)
Date Mon, 08 Jun 2020 23:52:20 GMT
This is an automated email from the ASF dual-hosted git repository.

jgus pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 1d24e2e  MINOR: Fix fetch session epoch comment in `FetchRequest.json` (#8802)
1d24e2e is described below

commit 1d24e2e3b2a119997fc6805f9c754a5ee286d7b2
Author: Jason Gustafson <jason@confluent.io>
AuthorDate: Mon Jun 8 16:51:48 2020 -0700

    MINOR: Fix fetch session epoch comment in `FetchRequest.json` (#8802)
    
    The current "about" string incorrectly describes the session epoch as the partition epoch.
Rename to `SessionEpoch` to make usage clearer. Also rename `MaxWait` to `MaxWaitMs` to make
the time unit clear and `FetchableTopic` to `FetchTopic` for consistency with `FetchPartition`.
    
    Reviewers: Ismael Juma <ismael@juma.me.uk>
---
 clients/src/main/resources/common/message/FetchRequest.json | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/clients/src/main/resources/common/message/FetchRequest.json b/clients/src/main/resources/common/message/FetchRequest.json
index 71fe379..727618c 100644
--- a/clients/src/main/resources/common/message/FetchRequest.json
+++ b/clients/src/main/resources/common/message/FetchRequest.json
@@ -49,7 +49,7 @@
   "fields": [
     { "name": "ReplicaId", "type": "int32", "versions": "0+",
       "about": "The broker ID of the follower, of -1 if this request is from a consumer."
},
-    { "name": "MaxWait", "type": "int32", "versions": "0+",
+    { "name": "MaxWaitMs", "type": "int32", "versions": "0+",
       "about": "The maximum time in milliseconds to wait for the response." },
     { "name": "MinBytes", "type": "int32", "versions": "0+",
       "about": "The minimum bytes to accumulate in the response." },
@@ -59,9 +59,9 @@
       "about": "This setting controls the visibility of transactional records. Using READ_UNCOMMITTED
(isolation_level = 0) makes all records visible. With READ_COMMITTED (isolation_level = 1),
non-transactional and COMMITTED transactional records are visible. To be more concrete, READ_COMMITTED
returns all data from offsets smaller than the current LSO (last stable offset), and enables
the inclusion of the list of aborted transactions in the result, which allows consumers to
discard ABO [...]
     { "name": "SessionId", "type": "int32", "versions": "7+", "default": "0", "ignorable":
false,
       "about": "The fetch session ID." },
-    { "name": "Epoch", "type": "int32", "versions": "7+", "default": "-1", "ignorable": false,
-      "about": "The epoch of the partition leader as known to the follower replica or a consumer."
},
-    { "name": "Topics", "type": "[]FetchableTopic", "versions": "0+",
+    { "name": "SessionEpoch", "type": "int32", "versions": "7+", "default": "-1", "ignorable":
false,
+      "about": "The fetch session epoch, which is used for ordering requests in a session"
},
+    { "name": "Topics", "type": "[]FetchTopic", "versions": "0+",
       "about": "The topics to fetch.", "fields": [
       { "name": "Name", "type": "string", "versions": "0+", "entityType": "topicName",
         "about": "The name of the topic to fetch." },


Mime
View raw message