kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject [kafka] branch trunk updated: MINOR: Upgrade spotbugs and spotbugsPlugin (#8790)
Date Wed, 03 Jun 2020 20:18:15 GMT
This is an automated email from the ASF dual-hosted git repository.

ijuma pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 1628844  MINOR: Upgrade spotbugs and spotbugsPlugin (#8790)
1628844 is described below

commit 162884409d1ac99f931c4291000d24bb98441fe6
Author: showuon <43372967+showuon@users.noreply.github.com>
AuthorDate: Thu Jun 4 04:17:31 2020 +0800

    MINOR: Upgrade spotbugs and spotbugsPlugin (#8790)
    
    Upgrade spotbugsPlugin to have clear output indicating where the error is.
    
    When investigating KAFKA-10081, I found the error output of spotbugs is very poor. It
doesn't even tell you where the error is and how many errors found, it will take a lot of
time for the developers to find out where the error is, and then fix it.
    ![image](https://user-images.githubusercontent.com/43372967/83590263-efc42a80-a587-11ea-95cf-e9097d9a662e.png)
    https://builds.apache.org/blue/organizations/jenkins/kafka-trunk-jdk8/detail/kafka-trunk-jdk8/4596/pipeline/
    
    Then, I found out there's a bug in spotbugsPlugin in V4.0.x, and got fixed in V4.2.x
    https://github.com/spotbugs/spotbugs-gradle-plugin/issues/210
    
    So, after upgrading to V4.2.x (I followed to the latest version V4.2.4), the output is
like this:
    ![image](https://user-images.githubusercontent.com/43372967/83590913-60b81200-a589-11ea-9a04-1449d693c2f2.png)
    So you know there's 1 error and you can also open the report file to find out the error.
    
    Upgraded to the latest bug fix release of spotbugs (4.0.3) while at it.
    
    Reviewers: Ismael Juma <ismael@juma.me.uk>
---
 gradle/dependencies.gradle | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 57fc4fd..7193f16 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -111,8 +111,8 @@ versions += [
   shadowPlugin: "5.2.0",
   slf4j: "1.7.30",
   snappy: "1.1.7.3",
-  spotbugs: "4.0.2",
-  spotbugsPlugin: "4.0.5",
+  spotbugs: "4.0.3",
+  spotbugsPlugin: "4.2.4",
   spotlessPlugin: "3.28.1",
   testRetryPlugin: "1.1.5",
   zinc: "1.3.5",


Mime
View raw message