kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject [kafka] branch 2.5 updated: KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests (#8786)
Date Wed, 03 Jun 2020 03:47:27 GMT
This is an automated email from the ASF dual-hosted git repository.

guozhang pushed a commit to branch 2.5
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.5 by this push:
     new 1f02b71  KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges
tests (#8786)
1f02b71 is described below

commit 1f02b712ba88ff37ef4b62bf6f5e3d7fdf0bea1e
Author: A. Sophie Blee-Goldman <sophie@confluent.io>
AuthorDate: Tue Jun 2 20:39:02 2020 -0700

    KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests (#8786)
    
    Minimum fix needed to stop this test failing and unblock others
    
    Co-authored-by: Luke Chen <showuon@gmail.com>
    
    Reviewers: Guozhang Wang <wangguoz@gmail.com>
---
 .../kafka/clients/consumer/internals/AbstractStickyAssignor.java       | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
index 9743688..a1af6d9 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
@@ -43,7 +43,7 @@ public abstract class AbstractStickyAssignor extends AbstractPartitionAssignor
{
 
     public static final int DEFAULT_GENERATION = -1;
 
-    private PartitionMovements partitionMovements = new PartitionMovements();
+    private PartitionMovements partitionMovements;
 
     // Keep track of the partitions being migrated from one consumer to another during assignment
     // so the cooperative assignor can adjust the assignment
@@ -72,6 +72,7 @@ public abstract class AbstractStickyAssignor extends AbstractPartitionAssignor
{
     @Override
     public Map<String, List<TopicPartition>> assign(Map<String, Integer>
partitionsPerTopic,
                                                     Map<String, Subscription> subscriptions)
{
+        partitionMovements = new PartitionMovements();
         Map<String, List<TopicPartition>> consumerToOwnedPartitions = new HashMap<>();
         if (allSubscriptionsEqual(partitionsPerTopic.keySet(), subscriptions, consumerToOwnedPartitions))
{
             log.debug("Detected that all consumers were subscribed to same set of topics,
invoking the "


Mime
View raw message