kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject [kafka] branch 2.6 updated: MINOR: Remove unused variable to fix spotBugs failure (#8779)
Date Tue, 02 Jun 2020 16:48:35 GMT
This is an automated email from the ASF dual-hosted git repository.

guozhang pushed a commit to branch 2.6
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.6 by this push:
     new c6e6d84  MINOR: Remove unused variable to fix spotBugs failure (#8779)
c6e6d84 is described below

commit c6e6d845a70be060b72e487b36bd54e26cbda839
Author: Nikolay <nizhikov@apache.org>
AuthorDate: Tue Jun 2 18:59:56 2020 +0300

    MINOR: Remove unused variable to fix spotBugs failure (#8779)
    
    Fixed spotBugs error introduced by c6633a1:
    
    >Dead store to isFreshAssignment in org.apache.kafka.clients.consumer.internals.AbstractStickyAssignor.generalAssign(Map,
Map)
    
    Reviewers: Ismael Juma <ismael@juma.me.uk>
---
 .../apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java  | 1 -
 1 file changed, 1 deletion(-)

diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
index d4e023c..353a225 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
@@ -274,7 +274,6 @@ public abstract class AbstractStickyAssignor extends AbstractPartitionAssignor
{
         Map<TopicPartition, ConsumerGenerationPair> prevAssignment = new HashMap<>();
 
         prepopulateCurrentAssignments(subscriptions, currentAssignment, prevAssignment);
-        boolean isFreshAssignment = currentAssignment.isEmpty();
 
         // a mapping of all topic partitions to all consumers that can be assigned to them
         final Map<TopicPartition, List<String>> partition2AllPotentialConsumers
= new HashMap<>();


Mime
View raw message