kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [kafka] branch 2.5 updated: KAFKA-9802; Increase transaction timeout in system tests to reduce flakiness (#8736)
Date Thu, 28 May 2020 04:00:25 GMT
This is an automated email from the ASF dual-hosted git repository.

jgus pushed a commit to branch 2.5
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.5 by this push:
     new f148968  KAFKA-9802; Increase transaction timeout in system tests to reduce flakiness
(#8736)
f148968 is described below

commit f1489686df8e5b0b9eaa3fff62ce07f3806a5c23
Author: Jason Gustafson <jason@confluent.io>
AuthorDate: Wed May 27 20:54:09 2020 -0700

    KAFKA-9802; Increase transaction timeout in system tests to reduce flakiness (#8736)
    
    We have been seeing increased flakiness in transaction system tests. I believe the cause
might be due to KIP-537, which increased the default zk session timeout from 6s to 18s and
the default replica lag timeout from 10s to 30s. In the system test, we use the default transaction
timeout of 10s. However, since the system test involves hard failures, the Produce request
could be blocking for as long as the max of these two in order to wait for an ISR shrink.
Hence this patch increases t [...]
    
    Reviewers: Bob Barrett <bob.barrett@confluent.io>, Ismael Juma <github@juma.me.uk>
---
 tests/kafkatest/services/transactional_message_copier.py | 3 ++-
 tests/kafkatest/tests/core/transactions_test.py          | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/kafkatest/services/transactional_message_copier.py b/tests/kafkatest/services/transactional_message_copier.py
index dc972d7..bea86a6 100644
--- a/tests/kafkatest/services/transactional_message_copier.py
+++ b/tests/kafkatest/services/transactional_message_copier.py
@@ -47,7 +47,8 @@ class TransactionalMessageCopier(KafkaPathResolverMixin, BackgroundThreadService
 
     def __init__(self, context, num_nodes, kafka, transactional_id, consumer_group,
                  input_topic, input_partition, output_topic, max_messages=-1,
-                 transaction_size=1000, transaction_timeout=None, enable_random_aborts=True,
use_group_metadata=False, group_mode=False):
+                 transaction_size=1000, transaction_timeout=None, enable_random_aborts=True,
+                 use_group_metadata=False, group_mode=False):
         super(TransactionalMessageCopier, self).__init__(context, num_nodes)
         self.kafka = kafka
         self.transactional_id = transactional_id
diff --git a/tests/kafkatest/tests/core/transactions_test.py b/tests/kafkatest/tests/core/transactions_test.py
index 2889f84..d958021 100644
--- a/tests/kafkatest/tests/core/transactions_test.py
+++ b/tests/kafkatest/tests/core/transactions_test.py
@@ -47,7 +47,7 @@ class TransactionsTest(Test):
         self.num_output_partitions = 3
         self.num_seed_messages = 100000
         self.transaction_size = 750
-        self.transaction_timeout = 10000
+        self.transaction_timeout = 40000
         self.consumer_group = "transactions-test-consumer-group"
 
         self.zk = ZookeeperService(test_context, num_nodes=1)


Mime
View raw message