kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cmcc...@apache.org
Subject [kafka] branch 2.4 updated: MINOR: Fix stale comment in partition reassignment javadoc (#7438)
Date Wed, 09 Oct 2019 18:49:17 GMT
This is an automated email from the ASF dual-hosted git repository.

cmccabe pushed a commit to branch 2.4
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.4 by this push:
     new c2e66e1  MINOR: Fix stale comment in partition reassignment javadoc (#7438)
c2e66e1 is described below

commit c2e66e12293a7f313663ec317bceafcb380c7605
Author: Stanislav Kozlovski <stanislav_kozlovski@outlook.com>
AuthorDate: Wed Oct 9 19:46:31 2019 +0100

    MINOR: Fix stale comment in partition reassignment javadoc (#7438)
    
    Reviewers: Colin P. McCabe <cmccabe@apache.org>, Viktor Somogyi <viktorsomogyi@gmail.com>
    (cherry picked from commit c620b73883c675ef7c49cd87a5873b3f9da3a5e1)
---
 core/src/main/scala/kafka/controller/KafkaController.scala | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/src/main/scala/kafka/controller/KafkaController.scala b/core/src/main/scala/kafka/controller/KafkaController.scala
index 642ebaa..e4679d3 100644
--- a/core/src/main/scala/kafka/controller/KafkaController.scala
+++ b/core/src/main/scala/kafka/controller/KafkaController.scala
@@ -562,8 +562,8 @@ class KafkaController(val config: KafkaConfig,
    *   . OVRS denotes the overlapping replica set - replicas which are part of the AR of
the ongoing reassignment and will be part of the overriding reassignment
    *       (it is essentially (RS - ORS) - URS)
    *
-   *   1 Set RS = ORS + OVRS, AR = OVRS, RS = [] in memory
-   *   2 Send LeaderAndIsr request with RS = ORS + OVRS, AR = [], RS = [] to all brokers
in ORS + OVRS
+   *   1 Set RS = ORS + OVRS, AR = OVRS, RR = [] in memory
+   *   2 Send LeaderAndIsr request with RS = ORS + OVRS, AR = OVRS, RR = [] to all brokers
in ORS + OVRS
    *     (because the ongoing reassignment is in phase A, we know we wouldn't have a leader
in URS
    *      unless a preferred leader election was triggered while the reassignment was happening)
    *   3 Replicas in URS -> Offline (force those replicas out of ISR)


Mime
View raw message