kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mj...@apache.org
Subject [kafka] branch 2.2 updated: KAFKA-8637: WriteBatch objects leak off-heap memory
Date Fri, 12 Jul 2019 17:20:04 GMT
This is an automated email from the ASF dual-hosted git repository.

mjsax pushed a commit to branch 2.2
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.2 by this push:
     new ca66c1e  KAFKA-8637: WriteBatch objects leak off-heap memory
ca66c1e is described below

commit ca66c1eef7fff184155d30945cc802d158211e85
Author: A. Sophie Blee-Goldman <sophie@confluent.io>
AuthorDate: Fri Jul 12 10:19:50 2019 -0700

    KAFKA-8637: WriteBatch objects leak off-heap memory
    
    Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>
---
 .../apache/kafka/streams/state/internals/RocksDBSegmentedBytesStore.java | 1 +
 1 file changed, 1 insertion(+)

diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBSegmentedBytesStore.java
b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBSegmentedBytesStore.java
index 0ed4e9d..cef8a34 100644
--- a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBSegmentedBytesStore.java
+++ b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBSegmentedBytesStore.java
@@ -211,6 +211,7 @@ public class RocksDBSegmentedBytesStore implements SegmentedBytesStore
{
                 final KeyValueSegment segment = entry.getKey();
                 final WriteBatch batch = entry.getValue();
                 segment.write(batch);
+                batch.close();
             }
         } catch (final RocksDBException e) {
             throw new ProcessorStateException("Error restoring batch to store " + this.name,
e);


Mime
View raw message