kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rsiva...@apache.org
Subject [kafka] branch trunk updated: MINOR: Fix version for ConnectDistributed system test, remove 0.9.0.1 compatibility test (#7023)
Date Tue, 02 Jul 2019 18:11:01 GMT
This is an automated email from the ASF dual-hosted git repository.

rsivaram pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 6f91096  MINOR: Fix version for ConnectDistributed system test, remove 0.9.0.1 compatibility
test (#7023)
6f91096 is described below

commit 6f91096c7d8056de68e443373c35f337213c7bba
Author: Randall Hauch <rhauch@gmail.com>
AuthorDate: Tue Jul 2 13:10:41 2019 -0500

    MINOR: Fix version for ConnectDistributed system test, remove 0.9.0.1 compatibility test
(#7023)
    
    Connect tests were using String version for KafkaService instead of the expected KafkaVersion
object. This broke due to recent changes to KafkaVersion. It turns out that the tests with
String version were running compatibility tests against `dev` brokers rather than the older
broker versions they were expecting to run against. When version was fixed, tests using 0.9.0.1
brokers started failing since new clients are not compatible with 0.9.0.1 brokers. So this
PR fixes version paramete [...]
    
    Reviewers: Ismael Juma <ismael@juma.me.uk>, Rajini Sivaram <rajinisivaram@googlemail.com>
---
 tests/kafkatest/tests/connect/connect_distributed_test.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/kafkatest/tests/connect/connect_distributed_test.py b/tests/kafkatest/tests/connect/connect_distributed_test.py
index cd1a15d..329d9f9 100644
--- a/tests/kafkatest/tests/connect/connect_distributed_test.py
+++ b/tests/kafkatest/tests/connect/connect_distributed_test.py
@@ -532,13 +532,11 @@ class ConnectDistributedTest(Test):
     @parametrize(broker_version=str(LATEST_0_10_2), auto_create_topics=False, security_protocol=SecurityConfig.PLAINTEXT,
connect_protocol='compatible')
     @parametrize(broker_version=str(LATEST_0_10_1), auto_create_topics=False, security_protocol=SecurityConfig.PLAINTEXT,
connect_protocol='compatible')
     @parametrize(broker_version=str(LATEST_0_10_0), auto_create_topics=True, security_protocol=SecurityConfig.PLAINTEXT,
connect_protocol='compatible')
-    @parametrize(broker_version=str(LATEST_0_9), auto_create_topics=True, security_protocol=SecurityConfig.PLAINTEXT,
connect_protocol='compatible')
     @parametrize(broker_version=str(DEV_BRANCH), auto_create_topics=False, security_protocol=SecurityConfig.PLAINTEXT,
connect_protocol='eager')
     @parametrize(broker_version=str(LATEST_0_11_0), auto_create_topics=False, security_protocol=SecurityConfig.PLAINTEXT,
connect_protocol='eager')
     @parametrize(broker_version=str(LATEST_0_10_2), auto_create_topics=False, security_protocol=SecurityConfig.PLAINTEXT,
connect_protocol='eager')
     @parametrize(broker_version=str(LATEST_0_10_1), auto_create_topics=False, security_protocol=SecurityConfig.PLAINTEXT,
connect_protocol='eager')
     @parametrize(broker_version=str(LATEST_0_10_0), auto_create_topics=True, security_protocol=SecurityConfig.PLAINTEXT,
connect_protocol='eager')
-    @parametrize(broker_version=str(LATEST_0_9), auto_create_topics=True, security_protocol=SecurityConfig.PLAINTEXT,
connect_protocol='eager')
     def test_broker_compatibility(self, broker_version, auto_create_topics, security_protocol,
connect_protocol):
         """
         Verify that Connect will start up with various broker versions with various configurations.

@@ -546,7 +544,7 @@ class ConnectDistributedTest(Test):
         or relies upon the broker to auto-create the topics (v0.10.0.x and before).
         """
         self.CONNECT_PROTOCOL = connect_protocol
-        self.setup_services(broker_version=broker_version, auto_create_topics=auto_create_topics,
security_protocol=security_protocol)
+        self.setup_services(broker_version=KafkaVersion(broker_version), auto_create_topics=auto_create_topics,
security_protocol=security_protocol)
         self.cc.set_configs(lambda node: self.render("connect-distributed.properties", node=node))
 
         self.cc.start()


Mime
View raw message