kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rsiva...@apache.org
Subject [kafka] branch 2.2 updated: KAFKA-8232; Test topic delete completion rather than intermediate state (#6581)
Date Mon, 15 Apr 2019 11:53:31 GMT
This is an automated email from the ASF dual-hosted git repository.

rsivaram pushed a commit to branch 2.2
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.2 by this push:
     new a7b8645  KAFKA-8232; Test topic delete completion rather than intermediate state
(#6581)
a7b8645 is described below

commit a7b864533fb58424a234f82b70a61f99aa470f5d
Author: Rajini Sivaram <rajinisivaram@googlemail.com>
AuthorDate: Mon Apr 15 12:42:23 2019 +0100

    KAFKA-8232; Test topic delete completion rather than intermediate state (#6581)
    
    Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
---
 .../test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala b/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
index 3ebd689..b2a68d2 100644
--- a/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
@@ -465,7 +465,7 @@ class TopicCommandWithAdminClientTest extends KafkaServerTestHarness with
Loggin
     val deletePath = DeleteTopicsTopicZNode.path(testTopicName)
     assertFalse("Delete path for topic shouldn't exist before deletion.", zkClient.pathExists(deletePath))
     topicService.deleteTopic(deleteOpts)
-    assertTrue("Delete path for topic should exist after deletion.", zkClient.pathExists(deletePath))
+    TestUtils.verifyTopicDeletion(zkClient, testTopicName, 1, servers)
   }
 
   @Test
@@ -483,7 +483,7 @@ class TopicCommandWithAdminClientTest extends KafkaServerTestHarness with
Loggin
     val deleteOffsetTopicPath = DeleteTopicsTopicZNode.path(Topic.GROUP_METADATA_TOPIC_NAME)
     assertFalse("Delete path for topic shouldn't exist before deletion.", zkClient.pathExists(deleteOffsetTopicPath))
     topicService.deleteTopic(deleteOffsetTopicOpts)
-    assertTrue("Delete path for topic should exist after deletion.", zkClient.pathExists(deleteOffsetTopicPath))
+    TestUtils.verifyTopicDeletion(zkClient, Topic.GROUP_METADATA_TOPIC_NAME, 1, servers)
   }
 
   @Test


Mime
View raw message