kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject [kafka] branch trunk updated: MINOR: Remove redundant access specifiers from metrics interfaces (#6527)
Date Tue, 09 Apr 2019 09:20:49 GMT
This is an automated email from the ASF dual-hosted git repository.

ijuma pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 0667fe2  MINOR: Remove redundant access specifiers from metrics interfaces (#6527)
0667fe2 is described below

commit 0667fe2bfda95b756faa589896b7da52622ef871
Author: highluck <yello1109@daum.net>
AuthorDate: Tue Apr 9 18:20:37 2019 +0900

    MINOR: Remove redundant access specifiers from metrics interfaces (#6527)
    
    Reviewers: Sönke Liebau <soenke.liebau@opencore.com>, Ismael Juma <ismael@juma.me.uk>
---
 .../main/java/org/apache/kafka/common/metrics/CompoundStat.java   | 4 ++--
 .../java/org/apache/kafka/common/metrics/MetricsReporter.java     | 8 ++++----
 clients/src/main/java/org/apache/kafka/common/metrics/Stat.java   | 2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java b/clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java
index 69f3efa..f2a7ac6 100644
--- a/clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java
+++ b/clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java
@@ -26,9 +26,9 @@ import java.util.List;
  */
 public interface CompoundStat extends Stat {
 
-    public List<NamedMeasurable> stats();
+    List<NamedMeasurable> stats();
 
-    public static class NamedMeasurable {
+    class NamedMeasurable {
 
         private final MetricName name;
         private final Measurable stat;
diff --git a/clients/src/main/java/org/apache/kafka/common/metrics/MetricsReporter.java b/clients/src/main/java/org/apache/kafka/common/metrics/MetricsReporter.java
index 55d6b25..49d0d6f 100644
--- a/clients/src/main/java/org/apache/kafka/common/metrics/MetricsReporter.java
+++ b/clients/src/main/java/org/apache/kafka/common/metrics/MetricsReporter.java
@@ -31,23 +31,23 @@ public interface MetricsReporter extends Configurable, AutoCloseable {
      * This is called when the reporter is first registered to initially register all existing
metrics
      * @param metrics All currently existing metrics
      */
-    public void init(List<KafkaMetric> metrics);
+    void init(List<KafkaMetric> metrics);
 
     /**
      * This is called whenever a metric is updated or added
      * @param metric
      */
-    public void metricChange(KafkaMetric metric);
+    void metricChange(KafkaMetric metric);
 
     /**
      * This is called whenever a metric is removed
      * @param metric
      */
-    public void metricRemoval(KafkaMetric metric);
+    void metricRemoval(KafkaMetric metric);
 
     /**
      * Called when the metrics repository is closed.
      */
-    public void close();
+    void close();
 
 }
diff --git a/clients/src/main/java/org/apache/kafka/common/metrics/Stat.java b/clients/src/main/java/org/apache/kafka/common/metrics/Stat.java
index 1ddf5be..fa5aa1a 100644
--- a/clients/src/main/java/org/apache/kafka/common/metrics/Stat.java
+++ b/clients/src/main/java/org/apache/kafka/common/metrics/Stat.java
@@ -27,6 +27,6 @@ public interface Stat {
      * @param value The value to record
      * @param timeMs The POSIX time in milliseconds this value occurred
      */
-    public void record(MetricConfig config, double value, long timeMs);
+    void record(MetricConfig config, double value, long timeMs);
 
 }


Mime
View raw message