kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rsiva...@apache.org
Subject [kafka] branch 2.2 updated: KAFKA-8091; Use commitSync to check connection failure in listener update test (#6450)
Date Fri, 15 Mar 2019 15:57:27 GMT
This is an automated email from the ASF dual-hosted git repository.

rsivaram pushed a commit to branch 2.2
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.2 by this push:
     new b14db14  KAFKA-8091; Use commitSync to check connection failure in listener update
test (#6450)
b14db14 is described below

commit b14db144ced6f9778fb9283498856059abaa41e3
Author: Rajini Sivaram <rajinisivaram@googlemail.com>
AuthorDate: Fri Mar 15 15:36:22 2019 +0000

    KAFKA-8091; Use commitSync to check connection failure in listener update test (#6450)
    
    The use of consumer.poll() made the test flaky since in some cases, it doesn't wait for
coordinator connection.
    
    Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
---
 .../integration/kafka/server/DynamicBrokerReconfigurationTest.scala     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
b/core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
index d1427b2..c14f41e 100644
--- a/core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
+++ b/core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
@@ -1315,7 +1315,7 @@ class DynamicBrokerReconfigurationTest extends ZooKeeperTestHarness
with SaslSet
     executors += executor
     val future = executor.submit(new Runnable() {
       def run() {
-        assertEquals(0, consumer.poll(100).count)
+        consumer.commitSync()
       }
     })
     verifyTimeout(future)


Mime
View raw message