From commits-return-10883-apmail-kafka-commits-archive=kafka.apache.org@kafka.apache.org Wed Dec 12 16:37:20 2018 Return-Path: X-Original-To: apmail-kafka-commits-archive@www.apache.org Delivered-To: apmail-kafka-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AF96518DCB for ; Wed, 12 Dec 2018 16:37:20 +0000 (UTC) Received: (qmail 35265 invoked by uid 500); 12 Dec 2018 16:37:20 -0000 Delivered-To: apmail-kafka-commits-archive@kafka.apache.org Received: (qmail 35225 invoked by uid 500); 12 Dec 2018 16:37:20 -0000 Mailing-List: contact commits-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list commits@kafka.apache.org Received: (qmail 35216 invoked by uid 99); 12 Dec 2018 16:37:20 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Dec 2018 16:37:20 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id F003082F11; Wed, 12 Dec 2018 16:37:19 +0000 (UTC) Date: Wed, 12 Dec 2018 16:37:19 +0000 To: "commits@kafka.apache.org" Subject: [kafka] branch trunk updated: KAFKA-7705; Fix and simplify producer config in javadoc example (#6000) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <154463263818.20336.10803807133136782944@gitbox.apache.org> From: jgus@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: kafka X-Git-Refname: refs/heads/trunk X-Git-Reftype: branch X-Git-Oldrev: 3ef6b0fce05a6ecdf7a703ff48680b16594b7bc4 X-Git-Newrev: 975b680bcd74661eeecf21052f6185cd637bbeda X-Git-Rev: 975b680bcd74661eeecf21052f6185cd637bbeda X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. jgus pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/kafka.git The following commit(s) were added to refs/heads/trunk by this push: new 975b680 KAFKA-7705; Fix and simplify producer config in javadoc example (#6000) 975b680 is described below commit 975b680bcd74661eeecf21052f6185cd637bbeda Author: hackerwin7 AuthorDate: Thu Dec 13 00:37:09 2018 +0800 KAFKA-7705; Fix and simplify producer config in javadoc example (#6000) The example in the producer's javadoc contained an inconsistent value for `delivery.timeout.ms`. This patch removes the inconsistent config and several unnecessary overrides in order to simplify the example. Reviewers: huxi , Ismael Juma , Jason Gustafson --- .../main/java/org/apache/kafka/clients/producer/KafkaProducer.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java b/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java index c9052e3..85ed9f8 100644 --- a/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java +++ b/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java @@ -96,10 +96,6 @@ import org.slf4j.Logger; * Properties props = new Properties(); * props.put("bootstrap.servers", "localhost:9092"); * props.put("acks", "all"); - * props.put("delivery.timeout.ms", 30000); - * props.put("batch.size", 16384); - * props.put("linger.ms", 1); - * props.put("buffer.memory", 33554432); * props.put("key.serializer", "org.apache.kafka.common.serialization.StringSerializer"); * props.put("value.serializer", "org.apache.kafka.common.serialization.StringSerializer"); *