kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [kafka] branch trunk updated: KAFKA-7705; Fix and simplify producer config in javadoc example (#6000)
Date Wed, 12 Dec 2018 16:37:19 GMT
This is an automated email from the ASF dual-hosted git repository.

jgus pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 975b680  KAFKA-7705; Fix and simplify producer config in javadoc example (#6000)
975b680 is described below

commit 975b680bcd74661eeecf21052f6185cd637bbeda
Author: hackerwin7 <hackerswin7@gmail.com>
AuthorDate: Thu Dec 13 00:37:09 2018 +0800

    KAFKA-7705; Fix and simplify producer config in javadoc example (#6000)
    
    The example in the producer's javadoc contained an inconsistent value for `delivery.timeout.ms`.
This patch removes the inconsistent config and several unnecessary overrides in order to simplify
the example.
    
    Reviewers: huxi <huxi_2b@hotmail.com>, Ismael Juma <ismael@juma.me.uk>, Jason
Gustafson <jason@confluent.io>
---
 .../main/java/org/apache/kafka/clients/producer/KafkaProducer.java    | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java b/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
index c9052e3..85ed9f8 100644
--- a/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
+++ b/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
@@ -96,10 +96,6 @@ import org.slf4j.Logger;
  * Properties props = new Properties();
  * props.put("bootstrap.servers", "localhost:9092");
  * props.put("acks", "all");
- * props.put("delivery.timeout.ms", 30000);
- * props.put("batch.size", 16384);
- * props.put("linger.ms", 1);
- * props.put("buffer.memory", 33554432);
  * props.put("key.serializer", "org.apache.kafka.common.serialization.StringSerializer");
  * props.put("value.serializer", "org.apache.kafka.common.serialization.StringSerializer");
  *


Mime
View raw message