From commits-return-10640-apmail-kafka-commits-archive=kafka.apache.org@kafka.apache.org Fri Oct 26 19:19:01 2018 Return-Path: X-Original-To: apmail-kafka-commits-archive@www.apache.org Delivered-To: apmail-kafka-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B2B018AB9 for ; Fri, 26 Oct 2018 19:19:01 +0000 (UTC) Received: (qmail 87522 invoked by uid 500); 26 Oct 2018 19:19:01 -0000 Delivered-To: apmail-kafka-commits-archive@kafka.apache.org Received: (qmail 87481 invoked by uid 500); 26 Oct 2018 19:19:01 -0000 Mailing-List: contact commits-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list commits@kafka.apache.org Received: (qmail 87472 invoked by uid 99); 26 Oct 2018 19:19:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Oct 2018 19:19:01 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 8F45387092; Fri, 26 Oct 2018 19:19:00 +0000 (UTC) Date: Fri, 26 Oct 2018 19:18:59 +0000 To: "commits@kafka.apache.org" Subject: [kafka] branch trunk updated: MINOR: Remove unused commitSync in ConsoleConsumer (#5845) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <154058153895.15624.4385008456776295532@gitbox.apache.org> From: ijuma@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: kafka X-Git-Refname: refs/heads/trunk X-Git-Reftype: branch X-Git-Oldrev: eda4a2904a863b04f6ea511a4cf1e2bd4806ad35 X-Git-Newrev: 51061792ca6120eeffe9845826962b49dc7939a1 X-Git-Rev: 51061792ca6120eeffe9845826962b49dc7939a1 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. ijuma pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/kafka.git The following commit(s) were added to refs/heads/trunk by this push: new 5106179 MINOR: Remove unused commitSync in ConsoleConsumer (#5845) 5106179 is described below commit 51061792ca6120eeffe9845826962b49dc7939a1 Author: Ismael Juma AuthorDate: Fri Oct 26 12:18:50 2018 -0700 MINOR: Remove unused commitSync in ConsoleConsumer (#5845) Dead code is confusing. Reviewers: Colin Patrick McCabe --- core/src/main/scala/kafka/tools/ConsoleConsumer.scala | 3 --- 1 file changed, 3 deletions(-) diff --git a/core/src/main/scala/kafka/tools/ConsoleConsumer.scala b/core/src/main/scala/kafka/tools/ConsoleConsumer.scala index 06705d5..be50be1 100755 --- a/core/src/main/scala/kafka/tools/ConsoleConsumer.scala +++ b/core/src/main/scala/kafka/tools/ConsoleConsumer.scala @@ -454,9 +454,6 @@ object ConsoleConsumer extends Logging { this.consumer.close() } - def commitSync() { - this.consumer.commitSync() - } } }