kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject [kafka] branch trunk updated: MINOR: Mark new Scala streams tests as integration tests (KIP-270 follow-up) (#5631)
Date Mon, 10 Sep 2018 16:53:11 GMT
This is an automated email from the ASF dual-hosted git repository.

guozhang pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 0d535b1  MINOR: Mark new Scala streams tests as integration tests (KIP-270 follow-up)
(#5631)
0d535b1 is described below

commit 0d535b167aa352dbc94b71d598e1ae2a2201b6d7
Author: Ewen Cheslack-Postava <me@ewencp.org>
AuthorDate: Mon Sep 10 09:53:02 2018 -0700

    MINOR: Mark new Scala streams tests as integration tests (KIP-270 follow-up) (#5631)
    
    Reviewers: Eno Thereska <eno.thereska@gmail.com>, John Roesler <vvcephei@users.noreply.github.com>,
Guozhang Wang <wangguoz@gmail.com>
---
 .../StreamToTableJoinScalaIntegrationTestImplicitSerdes.scala     | 3 +++
 .../test/scala/org/apache/kafka/streams/scala/WordCountTest.scala | 8 +++-----
 .../scala/utils/StreamToTableJoinScalaIntegrationTestBase.scala   | 4 +++-
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/StreamToTableJoinScalaIntegrationTestImplicitSerdes.scala
b/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/StreamToTableJoinScalaIntegrationTestImplicitSerdes.scala
index fd5f361..44c3605 100644
--- a/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/StreamToTableJoinScalaIntegrationTestImplicitSerdes.scala
+++ b/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/StreamToTableJoinScalaIntegrationTestImplicitSerdes.scala
@@ -22,7 +22,9 @@ import org.apache.kafka.streams._
 import org.apache.kafka.streams.scala.ImplicitConversions._
 import org.apache.kafka.streams.scala.kstream._
 import org.apache.kafka.streams.scala.utils.StreamToTableJoinScalaIntegrationTestBase
+import org.apache.kafka.test.IntegrationTest
 import org.junit._
+import org.junit.experimental.categories.Category
 
 /**
  * Test suite that does an example to demonstrate stream-table joins in Kafka Streams
@@ -33,6 +35,7 @@ import org.junit._
  * Note: In the current project settings SAM type conversion is turned off as it's experimental
in Scala 2.11.
  * Hence the native Java API based version is more verbose.
  */
+@Category(Array(classOf[IntegrationTest]))
 class StreamToTableJoinScalaIntegrationTestImplicitSerdes extends StreamToTableJoinScalaIntegrationTestBase
{
 
   @Test def testShouldCountClicksPerRegion(): Unit = {
diff --git a/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/WordCountTest.scala
b/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/WordCountTest.scala
index 5d858d8..9d821be 100644
--- a/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/WordCountTest.scala
+++ b/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/WordCountTest.scala
@@ -26,21 +26,18 @@ import org.scalatest.junit.JUnitSuite
 import org.junit.Assert._
 import org.junit._
 import org.junit.rules.TemporaryFolder
-
 import org.apache.kafka.streams.KeyValue
 import org.apache.kafka.streams._
 import org.apache.kafka.streams.scala.kstream._
 import org.apache.kafka.streams.kstream.Materialized
-
 import org.apache.kafka.streams.integration.utils.{EmbeddedKafkaCluster, IntegrationTestUtils}
 import org.apache.kafka.clients.consumer.ConsumerConfig
 import org.apache.kafka.clients.producer.ProducerConfig
-
 import org.apache.kafka.common.serialization._
 import org.apache.kafka.common.utils.MockTime
-import org.apache.kafka.test.TestUtils
-
+import org.apache.kafka.test.{IntegrationTest, TestUtils}
 import ImplicitConversions._
+import org.junit.experimental.categories.Category
 
 /**
  * Test suite that does a classic word count example.
@@ -51,6 +48,7 @@ import ImplicitConversions._
  * Note: In the current project settings SAM type conversion is turned off as it's experimental
in Scala 2.11.
  * Hence the native Java API based version is more verbose.
  */
+@Category(Array(classOf[IntegrationTest]))
 class WordCountTest extends JUnitSuite with WordCountTestData {
 
   private val privateCluster: EmbeddedKafkaCluster = new EmbeddedKafkaCluster(1)
diff --git a/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/utils/StreamToTableJoinScalaIntegrationTestBase.scala
b/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/utils/StreamToTableJoinScalaIntegrationTestBase.scala
index 9a3ee7f..baba5ea 100644
--- a/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/utils/StreamToTableJoinScalaIntegrationTestBase.scala
+++ b/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/utils/StreamToTableJoinScalaIntegrationTestBase.scala
@@ -24,8 +24,9 @@ import org.apache.kafka.common.serialization._
 import org.apache.kafka.common.utils.MockTime
 import org.apache.kafka.streams._
 import org.apache.kafka.streams.integration.utils.{EmbeddedKafkaCluster, IntegrationTestUtils}
-import org.apache.kafka.test.TestUtils
+import org.apache.kafka.test.{IntegrationTest, TestUtils}
 import org.junit._
+import org.junit.experimental.categories.Category
 import org.junit.rules.TemporaryFolder
 import org.scalatest.junit.JUnitSuite
 
@@ -33,6 +34,7 @@ import org.scalatest.junit.JUnitSuite
  * Test suite base that prepares Kafka cluster for stream-table joins in Kafka Streams
  * <p>
  */
+@Category(Array(classOf[IntegrationTest]))
 class StreamToTableJoinScalaIntegrationTestBase extends JUnitSuite with StreamToTableJoinTestData
{
 
   private val privateCluster: EmbeddedKafkaCluster = new EmbeddedKafkaCluster(1)


Mime
View raw message