kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [kafka] branch trunk updated: MINOR: Log AdminClient configs (#5457)
Date Tue, 07 Aug 2018 00:56:01 GMT
This is an automated email from the ASF dual-hosted git repository.

jgus pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new cf98144  MINOR: Log AdminClient configs (#5457)
cf98144 is described below

commit cf981443e493f134bf78b97ad83e5bedddb3fde0
Author: Manikumar Reddy O <manikumar.reddy@gmail.com>
AuthorDate: Tue Aug 7 06:25:55 2018 +0530

    MINOR: Log AdminClient configs (#5457)
    
    Reviewers: Sriharsha Chintalapani <sriharsha@apache.org>, Jason Gustafson <jason@confluent.io>
---
 .../src/main/java/org/apache/kafka/clients/admin/AdminClient.java   | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java b/clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java
index 75c93b6..fdda622 100644
--- a/clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java
+++ b/clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java
@@ -51,7 +51,7 @@ public abstract class AdminClient implements AutoCloseable {
      * @return The new KafkaAdminClient.
      */
     public static AdminClient create(Properties props) {
-        return KafkaAdminClient.createInternal(new AdminClientConfig(props), null);
+        return KafkaAdminClient.createInternal(new AdminClientConfig(props, true), null);
     }
 
     /**
@@ -61,7 +61,7 @@ public abstract class AdminClient implements AutoCloseable {
      * @return The new KafkaAdminClient.
      */
     public static AdminClient create(Map<String, Object> conf) {
-        return KafkaAdminClient.createInternal(new AdminClientConfig(conf), null);
+        return KafkaAdminClient.createInternal(new AdminClientConfig(conf, true), null);
     }
 
     /**
@@ -773,8 +773,6 @@ public abstract class AdminClient implements AutoCloseable {
 
     /**
      * Get the metrics kept by the adminClient
-     *
-     * @return
      */
     public abstract Map<MetricName, ? extends Metric> metrics();
 }


Mime
View raw message