kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [kafka] branch trunk updated: KAFKA-4994; Remove findbugs suppression for OffsetStorageWriter (#5385)
Date Thu, 19 Jul 2018 06:05:56 GMT
This is an automated email from the ASF dual-hosted git repository.

jgus pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 3205989  KAFKA-4994; Remove findbugs suppression for OffsetStorageWriter (#5385)
3205989 is described below

commit 3205989d585c3939254911ee0757eeaaeb15ae27
Author: Colin Patrick McCabe <colin@cmccabe.xyz>
AuthorDate: Wed Jul 18 23:05:52 2018 -0700

    KAFKA-4994; Remove findbugs suppression for OffsetStorageWriter (#5385)
    
    Remove findbugs suppression for OffsetStorageWriter because it is no longer needed.
---
 gradle/findbugs-exclude.xml | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/gradle/findbugs-exclude.xml b/gradle/findbugs-exclude.xml
index 21c8891..0998185 100644
--- a/gradle/findbugs-exclude.xml
+++ b/gradle/findbugs-exclude.xml
@@ -171,13 +171,6 @@ For a detailed description of findbugs bug categories, see http://findbugs.sourc
     </Match>
 
     <Match>
-        <!-- Suppress some inconsistent synchronization warnings.  TODO: fix these.  See
-             KAFKA-4994. -->
-        <Class name="org.apache.kafka.connect.storage.OffsetStorageWriter"/>
-        <Bug pattern="IS2_INCONSISTENT_SYNC"/>
-    </Match>
-
-    <Match>
         <!-- Suppress a warning about intentional switch statement fallthrough. -->
         <Class name="org.apache.kafka.common.security.authenticator.SaslClientAuthenticator"/>
         <Method name="authenticate"/>


Mime
View raw message