kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [kafka] branch 0.10.2 updated: Revert "MINOR: Use kill_java_processes when killing ConsoleConsumer in system tests (#5297)"
Date Mon, 02 Jul 2018 16:33:25 GMT
This is an automated email from the ASF dual-hosted git repository.

jgus pushed a commit to branch 0.10.2
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/0.10.2 by this push:
     new f9f52eb  Revert "MINOR: Use kill_java_processes when killing ConsoleConsumer in system
tests (#5297)"
f9f52eb is described below

commit f9f52ebeb146e33f735646ad9998c14e0b02e520
Author: Jason Gustafson <jason@confluent.io>
AuthorDate: Mon Jul 2 09:32:58 2018 -0700

    Revert "MINOR: Use kill_java_processes when killing ConsoleConsumer in system tests (#5297)"
    
    This reverts commit d1b7a17f58daf60b0d73137d90fdfc059b84fbe8.
---
 tests/kafkatest/services/console_consumer.py | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/tests/kafkatest/services/console_consumer.py b/tests/kafkatest/services/console_consumer.py
index 42a0341..d55d012 100644
--- a/tests/kafkatest/services/console_consumer.py
+++ b/tests/kafkatest/services/console_consumer.py
@@ -17,6 +17,7 @@ import itertools
 import os
 
 from ducktape.services.background_thread import BackgroundThreadService
+from ducktape.cluster.remoteaccount import RemoteCommandError
 
 from kafkatest.directory_layout.kafka_path import KafkaPathResolverMixin
 from kafkatest.services.monitor.jmx import JmxMixin
@@ -220,7 +221,12 @@ class ConsoleConsumer(KafkaPathResolverMixin, JmxMixin, BackgroundThreadService)
         return cmd
 
     def pids(self, node):
-        return node.account.java_pids(self.java_class_name())
+        try:
+            cmd = "ps ax | grep -i console_consumer | grep java | grep -v grep | awk '{print
$1}'"
+            pid_arr = [pid for pid in node.account.ssh_capture(cmd, allow_fail=True, callback=int)]
+            return pid_arr
+        except (RemoteCommandError, ValueError) as e:
+            return []
 
     def alive(self, node):
         return len(self.pids(node)) > 0
@@ -270,9 +276,7 @@ class ConsoleConsumer(KafkaPathResolverMixin, JmxMixin, BackgroundThreadService)
         BackgroundThreadService.start_node(self, node)
 
     def stop_node(self, node):
-        self.logger.info("%s Stopping node %s" % (self.__class__.__name__, str(node.account)))
-        node.account.kill_java_processes(self.java_class_name(),
-                                         clean_shutdown=True, allow_fail=True)
+        node.account.kill_process("console_consumer", allow_fail=True)
 
         stopped = self.wait_node(node, timeout_sec=self.stop_timeout_sec)
         assert stopped, "Node %s: did not stop within the specified timeout of %s seconds"
% \
@@ -283,13 +287,10 @@ class ConsoleConsumer(KafkaPathResolverMixin, JmxMixin, BackgroundThreadService)
             self.logger.warn("%s %s was still alive at cleanup time. Killing forcefully..."
%
                              (self.__class__.__name__, node.account))
         JmxMixin.clean_node(self, node)
-        node.account.kill_java_processes(self.java_class_name(), clean_shutdown=False, allow_fail=True)
+        node.account.kill_process("java", clean_shutdown=False, allow_fail=True)
         node.account.ssh("rm -rf %s" % ConsoleConsumer.PERSISTENT_ROOT, allow_fail=False)
         self.security_config.clean_node(node)
 
-    def java_class_name(self):
-        return "ConsoleConsumer"
-
     def has_partitions_assigned(self, node):
        if self.new_consumer is False:
           return False


Mime
View raw message