From commits-return-9484-apmail-kafka-commits-archive=kafka.apache.org@kafka.apache.org Wed May 9 06:02:41 2018 Return-Path: X-Original-To: apmail-kafka-commits-archive@www.apache.org Delivered-To: apmail-kafka-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7B509185FF for ; Wed, 9 May 2018 06:02:41 +0000 (UTC) Received: (qmail 86394 invoked by uid 500); 9 May 2018 06:02:41 -0000 Delivered-To: apmail-kafka-commits-archive@kafka.apache.org Received: (qmail 86350 invoked by uid 500); 9 May 2018 06:02:41 -0000 Mailing-List: contact commits-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list commits@kafka.apache.org Received: (qmail 86335 invoked by uid 99); 9 May 2018 06:02:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 May 2018 06:02:41 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 7FB0C81E05; Wed, 9 May 2018 06:02:40 +0000 (UTC) Date: Wed, 09 May 2018 06:02:40 +0000 To: "commits@kafka.apache.org" Subject: [kafka] branch trunk updated: MINOR: Fix trace logging in ReplicaManager (#4916) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <152584575993.1450.6374431287476774135@gitbox.apache.org> From: ijuma@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: kafka X-Git-Refname: refs/heads/trunk X-Git-Reftype: branch X-Git-Oldrev: 7afcb3a64c53831f05f99037dfa07aba1d396c48 X-Git-Newrev: b27e098a7dbcc07c6abb758de570596c74722025 X-Git-Rev: b27e098a7dbcc07c6abb758de570596c74722025 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. ijuma pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/kafka.git The following commit(s) were added to refs/heads/trunk by this push: new b27e098 MINOR: Fix trace logging in ReplicaManager (#4916) b27e098 is described below commit b27e098a7dbcc07c6abb758de570596c74722025 Author: Colin Patrick McCabe AuthorDate: Tue May 8 23:02:33 2018 -0700 MINOR: Fix trace logging in ReplicaManager (#4916) Reviewers: Ismael Juma --- core/src/main/scala/kafka/server/ReplicaManager.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/scala/kafka/server/ReplicaManager.scala b/core/src/main/scala/kafka/server/ReplicaManager.scala index da50117..85c66a5 100644 --- a/core/src/main/scala/kafka/server/ReplicaManager.scala +++ b/core/src/main/scala/kafka/server/ReplicaManager.scala @@ -754,8 +754,8 @@ class ReplicaManager(val config: KafkaConfig, brokerTopicStats.topicStats(topicPartition.topic).messagesInRate.mark(numAppendedMessages) brokerTopicStats.allTopicsStats.messagesInRate.mark(numAppendedMessages) - trace("%d bytes written to log %s-%d beginning at offset %d and ending at offset %d" - .format(records.sizeInBytes, topicPartition.topic, topicPartition.partition, info.firstOffset, info.lastOffset)) + trace(s"${records.sizeInBytes} written to log ${topicPartition} beginning at offset " + + s"${info.firstOffset.getOrElse(-1)} and ending at offset ${info.lastOffset}") (topicPartition, LogAppendResult(info)) } catch { // NOTE: Failed produce requests metric is not incremented for known exceptions -- To stop receiving notification emails like this one, please contact ijuma@apache.org.