From commits-return-9235-apmail-kafka-commits-archive=kafka.apache.org@kafka.apache.org Mon Mar 19 20:30:20 2018 Return-Path: X-Original-To: apmail-kafka-commits-archive@www.apache.org Delivered-To: apmail-kafka-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1CA0218728 for ; Mon, 19 Mar 2018 20:30:20 +0000 (UTC) Received: (qmail 4294 invoked by uid 500); 19 Mar 2018 20:30:20 -0000 Delivered-To: apmail-kafka-commits-archive@kafka.apache.org Received: (qmail 4254 invoked by uid 500); 19 Mar 2018 20:30:19 -0000 Mailing-List: contact commits-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list commits@kafka.apache.org Received: (qmail 4245 invoked by uid 99); 19 Mar 2018 20:30:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2018 20:30:19 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 5584B80A0A; Mon, 19 Mar 2018 20:30:19 +0000 (UTC) Date: Mon, 19 Mar 2018 20:30:19 +0000 To: "commits@kafka.apache.org" Subject: [kafka] branch trunk updated: MINOR: KafkaFutureImpl#addWaiter should be protected (#4734) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <152149141885.5720.15774619678238282394@gitbox.apache.org> From: jgus@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: kafka X-Git-Refname: refs/heads/trunk X-Git-Reftype: branch X-Git-Oldrev: 6fab286da2735517f6d0c945328abcb77fa0a7a4 X-Git-Newrev: 27bb3ccaceae52c730b2c02d72c63a84060966f1 X-Git-Rev: 27bb3ccaceae52c730b2c02d72c63a84060966f1 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. jgus pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/kafka.git The following commit(s) were added to refs/heads/trunk by this push: new 27bb3cc MINOR: KafkaFutureImpl#addWaiter should be protected (#4734) 27bb3cc is described below commit 27bb3ccaceae52c730b2c02d72c63a84060966f1 Author: Colin Patrick McCabe AuthorDate: Mon Mar 19 13:30:13 2018 -0700 MINOR: KafkaFutureImpl#addWaiter should be protected (#4734) KafkaFutureImpl#addWaiter should be protected, just like KafkaFuture#addWaiter. As described in KIP-218, whenComplete is the public API, not addWaiter. --- .../main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java b/clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java index 049ed49..b1e5b6d 100644 --- a/clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java +++ b/clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java @@ -192,7 +192,7 @@ public class KafkaFutureImpl extends KafkaFuture { return future; } - public synchronized void addWaiter(BiConsumer action) { + protected synchronized void addWaiter(BiConsumer action) { if (exception != null) { action.accept(null, exception); } else if (done) { -- To stop receiving notification emails like this one, please contact jgus@apache.org.