kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mj...@apache.org
Subject [kafka] branch 0.10.2 updated: MINOR: Fix typos in docs and address some missed review comments (#4778)
Date Tue, 27 Mar 2018 20:44:27 GMT
This is an automated email from the ASF dual-hosted git repository.

mjsax pushed a commit to branch 0.10.2
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/0.10.2 by this push:
     new 94e17b4  MINOR: Fix typos in docs and address some missed review comments (#4778)
94e17b4 is described below

commit 94e17b4c37b563b5c522d7ff494581b03df54b7c
Author: Matthias J. Sax <mjsax@apache.org>
AuthorDate: Tue Mar 27 13:44:23 2018 -0700

    MINOR: Fix typos in docs and address some missed review comments (#4778)
    
    Reviewers: Bill Bejeck <bill@confluent.io>, John Roesler <john@confluent.io>,
Guozhang Wang <guozhang@confluent.io>
---
 docs/streams.html                                                       | 2 +-
 docs/upgrade.html                                                       | 2 +-
 .../org/apache/kafka/streams/integration/FanoutIntegrationTest.java     | 2 +-
 .../src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java   | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/streams.html b/docs/streams.html
index d691e63..a82c44a 100644
--- a/docs/streams.html
+++ b/docs/streams.html
@@ -813,7 +813,7 @@ $ java -cp path-to-app-fatjar.jar com.example.MyStreamsApp
         for a complete list of API changes.
         Upgrading to 0.10.2.2 requires two rolling bounces with config <code>upgrade.from="0.10.0"</code>
set for first upgrade phase
         (cf. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-268%3A+Simplify+Kafka+Streams+Rebalance+Metadata+Upgrade">KIP-268</a>).
-        As an alternative, and offline upgrade is also possible.
+        As an alternative, an offline upgrade is also possible.
         </p>
         <ul>
             <li> prepare your application instances for a rolling bounce and make sure
that config <code>upgrade.from=</code> is set to <code>"0.10.0"</code>
for new version 0.10.2.2 </li>
diff --git a/docs/upgrade.html b/docs/upgrade.html
index 7747762..825e249 100644
--- a/docs/upgrade.html
+++ b/docs/upgrade.html
@@ -148,7 +148,7 @@ only support 0.10.1.x or later brokers while 0.10.1.x brokers also support
older
          Thus, you need to update and recompile your code. Just swapping the Kafka Streams
library jar file will not work and will break your application. </li>
     <li> Upgrading from 0.10.0.x to 0.10.1.2 requires two rolling bounces with config
<code>upgrade.from="0.10.0"</code> set for first upgrade phase
          (cf. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-268%3A+Simplify+Kafka+Streams+Rebalance+Metadata+Upgrade">KIP-268</a>).
-         As an alternative, and offline upgrade is also possible.
+         As an alternative, an offline upgrade is also possible.
         <ul>
             <li> prepare your application instances for a rolling bounce and make sure
that config <code>upgrade.from</code> is set to <code>"0.10.0"</code>
for new version 0.10.1.2 </li>
             <li> bounce each instance of your application once </li>
diff --git a/streams/src/test/java/org/apache/kafka/streams/integration/FanoutIntegrationTest.java
b/streams/src/test/java/org/apache/kafka/streams/integration/FanoutIntegrationTest.java
index 1256824..b46eaef 100644
--- a/streams/src/test/java/org/apache/kafka/streams/integration/FanoutIntegrationTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/integration/FanoutIntegrationTest.java
@@ -113,7 +113,7 @@ public class FanoutIntegrationTest {
         final Properties streamsConfiguration = new Properties();
         streamsConfiguration.put(StreamsConfig.APPLICATION_ID_CONFIG, "fanout-integration-test");
         streamsConfiguration.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, CLUSTER.bootstrapServers());
-        streamsConfiguration.setProperty(StreamsConfig.STATE_DIR_CONFIG, TestUtils.tempDirectory().getPath());
+        streamsConfiguration.setProperty(StreamsConfig.STATE_DIR_CONFIG, TestUtils.tempDirectory().getAbsolutePath());
         streamsConfiguration.put(StreamsConfig.VALUE_SERDE_CLASS_CONFIG, Serdes.String().getClass().getName());
         streamsConfiguration.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest");
         streamsConfiguration.put(StreamsConfig.CACHE_MAX_BYTES_BUFFERING_CONFIG, cacheSizeBytes);
diff --git a/streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java b/streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java
index 9f59b11..f041784 100644
--- a/streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java
+++ b/streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java
@@ -115,7 +115,7 @@ public class SmokeTestClient extends SmokeTestUtil {
             }
         });
 
-        data.process(SmokeTestUtil.<String, Integer>printProcessorSupplier("data"));
+        data.process(SmokeTestUtil.printProcessorSupplier("data"));
 
         // min
         KGroupedStream<String, Integer>

-- 
To stop receiving notification emails like this one, please contact
mjsax@apache.org.

Mime
View raw message