kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject kafka git commit: MINOR: Improve EOS related config docs
Date Fri, 01 Dec 2017 22:39:50 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 8c1e1cf27 -> d1e0443ba


MINOR: Improve EOS related config docs

Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Jason Gustafson <jason@confluent.io>, Guozhang Wang <wangguoz@gmail.com>

Closes #4284 from mjsax/minor-improve-eos-docs


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/d1e0443b
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/d1e0443b
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/d1e0443b

Branch: refs/heads/trunk
Commit: d1e0443bac769c10598bbdeddf6d7e06f2fdf7e4
Parents: 8c1e1cf
Author: Matthias J. Sax <matthias@confluent.io>
Authored: Fri Dec 1 14:39:46 2017 -0800
Committer: Guozhang Wang <wangguoz@gmail.com>
Committed: Fri Dec 1 14:39:46 2017 -0800

----------------------------------------------------------------------
 .../java/org/apache/kafka/clients/producer/ProducerConfig.java    | 3 ++-
 streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/d1e0443b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
index 2dcf38c..f9bf3f4 100644
--- a/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
+++ b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
@@ -217,7 +217,8 @@ public class ProducerConfig extends AbstractConfig {
     public static final String TRANSACTIONAL_ID_CONFIG = "transactional.id";
     public static final String TRANSACTIONAL_ID_DOC = "The TransactionalId to use for transactional
delivery. This enables reliability semantics which span multiple producer sessions since it
allows the client to guarantee that transactions using the same TransactionalId have been
completed prior to starting any new transactions. If no TransactionalId is provided, then
the producer is limited to idempotent delivery. " +
             "Note that enable.idempotence must be enabled if a TransactionalId is configured.
" +
-            "The default is empty, which means transactions cannot be used.";
+            "The default is <code>null</code>, which means transactions cannot
be used. " +
+            "Note that transactions requires a cluster of at least three brokers by default
what is the recommended setting for production; for development you can change this, by adjusting
broker setting `transaction.state.log.replication.factor`.";
 
     static {
         CONFIG = new ConfigDef().define(BOOTSTRAP_SERVERS_CONFIG, Type.LIST, Importance.HIGH,
CommonClientConfigs.BOOTSTRAP_SERVERS_DOC)

http://git-wip-us.apache.org/repos/asf/kafka/blob/d1e0443b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
----------------------------------------------------------------------
diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
index e1f2b09..26919c6 100644
--- a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
+++ b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
@@ -238,7 +238,8 @@ public class StreamsConfig extends AbstractConfig {
 
     /** {@code processing.guarantee} */
     public static final String PROCESSING_GUARANTEE_CONFIG = "processing.guarantee";
-    private static final String PROCESSING_GUARANTEE_DOC = "The processing guarantee that
should be used. Possible values are <code>" + AT_LEAST_ONCE + "</code> (default)
and <code>" + EXACTLY_ONCE + "</code>.";
+    private static final String PROCESSING_GUARANTEE_DOC = "The processing guarantee that
should be used. Possible values are <code>" + AT_LEAST_ONCE + "</code> (default)
and <code>" + EXACTLY_ONCE + "</code>. " +
+        "Note that exactly-once processing requires a cluster of at least three brokers by
default what is the recommended setting for production; for development you can change this,
by adjusting broker setting `transaction.state.log.replication.factor`.";
 
     /** {@code receive.buffer.bytes} */
     public static final String RECEIVE_BUFFER_CONFIG = CommonClientConfigs.RECEIVE_BUFFER_CONFIG;


Mime
View raw message