kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject kafka git commit: MINOR: Fix race condition in Streams EOS system test
Date Thu, 21 Dec 2017 02:44:49 GMT
Repository: kafka
Updated Branches:
  refs/heads/1.0 2f9808689 -> dfdff16ac


MINOR: Fix race condition in Streams EOS system test

We should start the process only within the `with` block, otherwise the bytes parameter would
cause a race condition that result in false alarms of system test failures.

Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Ewen Cheslack-Postava <me@ewencp.org>

Closes #4348 from guozhangwang/KMinor-fix-eos-test

(cherry picked from commit 7d6f6f7320f2058d1108224eefe615e333955721)
Signed-off-by: Guozhang Wang <wangguoz@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/dfdff16a
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/dfdff16a
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/dfdff16a

Branch: refs/heads/1.0
Commit: dfdff16ac85c2ea52b9958f043fdf99ed61a099e
Parents: 2f98086
Author: Guozhang Wang <wangguoz@gmail.com>
Authored: Wed Dec 20 18:44:36 2017 -0800
Committer: Guozhang Wang <wangguoz@gmail.com>
Committed: Wed Dec 20 18:44:45 2017 -0800

----------------------------------------------------------------------
 tests/kafkatest/tests/streams/streams_eos_test.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/dfdff16a/tests/kafkatest/tests/streams/streams_eos_test.py
----------------------------------------------------------------------
diff --git a/tests/kafkatest/tests/streams/streams_eos_test.py b/tests/kafkatest/tests/streams/streams_eos_test.py
index 0863e25..623d036 100644
--- a/tests/kafkatest/tests/streams/streams_eos_test.py
+++ b/tests/kafkatest/tests/streams/streams_eos_test.py
@@ -118,8 +118,8 @@ class StreamsEosTest(KafkaTest):
         verifier.node.account.ssh("grep ALL-RECORDS-DELIVERED %s" % verifier.STDOUT_FILE,
allow_fail=False)
 
     def add_streams(self, processor):
-        processor.start()
         with processor.node.account.monitor_log(processor.STDOUT_FILE) as monitor:
+            processor.start()
             self.wait_for_startup(monitor, processor)
 
     def add_streams2(self, running_processor, processor_to_be_started):


Mime
View raw message