kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject kafka git commit: MINOR: Improve EOS related config docs
Date Fri, 01 Dec 2017 22:45:35 GMT
Repository: kafka
Updated Branches:
  refs/heads/1.0 78379c3ba -> bf98d7b36


MINOR: Improve EOS related config docs

Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Jason Gustafson <jason@confluent.io>, Guozhang Wang <wangguoz@gmail.com>

Closes #4284 from mjsax/minor-improve-eos-docs


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/bf98d7b3
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/bf98d7b3
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/bf98d7b3

Branch: refs/heads/1.0
Commit: bf98d7b365fd9ef09ad388c503a470585a0bbbfc
Parents: 78379c3
Author: Matthias J. Sax <matthias@confluent.io>
Authored: Fri Dec 1 14:39:46 2017 -0800
Committer: Guozhang Wang <wangguoz@gmail.com>
Committed: Fri Dec 1 14:45:28 2017 -0800

----------------------------------------------------------------------
 .../java/org/apache/kafka/clients/producer/ProducerConfig.java    | 3 ++-
 streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/bf98d7b3/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
index c1ae579..b8c59f0 100644
--- a/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
+++ b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
@@ -217,7 +217,8 @@ public class ProducerConfig extends AbstractConfig {
     public static final String TRANSACTIONAL_ID_CONFIG = "transactional.id";
     public static final String TRANSACTIONAL_ID_DOC = "The TransactionalId to use for transactional
delivery. This enables reliability semantics which span multiple producer sessions since it
allows the client to guarantee that transactions using the same TransactionalId have been
completed prior to starting any new transactions. If no TransactionalId is provided, then
the producer is limited to idempotent delivery. " +
             "Note that enable.idempotence must be enabled if a TransactionalId is configured.
" +
-            "The default is empty, which means transactions cannot be used.";
+            "The default is <code>null</code>, which means transactions cannot
be used. " +
+            "Note that transactions requires a cluster of at least three brokers by default
what is the recommended setting for production; for development you can change this, by adjusting
broker setting `transaction.state.log.replication.factor`.";
 
     static {
         CONFIG = new ConfigDef().define(BOOTSTRAP_SERVERS_CONFIG, Type.LIST, Importance.HIGH,
CommonClientConfigs.BOOTSTRAP_SERVERS_DOC)

http://git-wip-us.apache.org/repos/asf/kafka/blob/bf98d7b3/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
----------------------------------------------------------------------
diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
index 8fc37f2..7fc3d5c 100644
--- a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
+++ b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
@@ -232,7 +232,8 @@ public class StreamsConfig extends AbstractConfig {
 
     /** {@code processing.guarantee} */
     public static final String PROCESSING_GUARANTEE_CONFIG = "processing.guarantee";
-    private static final String PROCESSING_GUARANTEE_DOC = "The processing guarantee that
should be used. Possible values are <code>" + AT_LEAST_ONCE + "</code> (default)
and <code>" + EXACTLY_ONCE + "</code>.";
+    private static final String PROCESSING_GUARANTEE_DOC = "The processing guarantee that
should be used. Possible values are <code>" + AT_LEAST_ONCE + "</code> (default)
and <code>" + EXACTLY_ONCE + "</code>. " +
+        "Note that exactly-once processing requires a cluster of at least three brokers by
default what is the recommended setting for production; for development you can change this,
by adjusting broker setting `transaction.state.log.replication.factor`.";
 
     /** {@code receive.buffer.bytes} */
     public static final String RECEIVE_BUFFER_CONFIG = CommonClientConfigs.RECEIVE_BUFFER_CONFIG;


Mime
View raw message