kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From damian...@apache.org
Subject kafka git commit: MINOR: add hint for setting an uncaught exception handler to JavaDocs
Date Mon, 23 Oct 2017 09:33:59 GMT
Repository: kafka
Updated Branches:
  refs/heads/1.0 5ee157126 -> 2a3219413

MINOR: add hint for setting an uncaught exception handler to JavaDocs

Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Bill Bejeck <bill@confluent.io>, Damian Guy <damian.guy@gmail.com>

Closes #4104 from mjsax/minor-uncaught-exception-handler

(cherry picked from commit c216adb4bbf8306977380a1ec371380e30137765)
Signed-off-by: Damian Guy <damian.guy@gmail.com>

Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/2a321941
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/2a321941
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/2a321941

Branch: refs/heads/1.0
Commit: 2a321941387c7739f2fbbbe592d017b703223ada
Parents: 5ee1571
Author: Matthias J. Sax <matthias@confluent.io>
Authored: Mon Oct 23 10:33:51 2017 +0100
Committer: Damian Guy <damian.guy@gmail.com>
Committed: Mon Oct 23 10:34:04 2017 +0100

 .../src/main/java/org/apache/kafka/streams/KafkaStreams.java   | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java b/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
index ae4ef34..6e48f19 100644
--- a/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
+++ b/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
@@ -723,6 +723,12 @@ public class KafkaStreams {
      * Start the {@code KafkaStreams} instance by starting all its threads.
      * This function is expected to be called only once during the life cycle of the client.
      * <p>
+     * Because threads are started in the background, this method does not block.
+     * As a consequence, any fatal exception that happens during processing is by default
only logged.
+     * If you want to be notified about dying threads, you can
+     * {@link #setUncaughtExceptionHandler(Thread.UncaughtExceptionHandler) register an uncaught
exception handler}
+     * before starting the {@code KafkaStreams} instance.
+     * <p>
      * Note, for brokers with version {@code 0.9.x} or lower, the broker version cannot be
      * There will be no error and the client will hang and retry to verify the broker version
until it
      * {@link StreamsConfig#REQUEST_TIMEOUT_MS_CONFIG times out}.

View raw message