kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: MINOR: Deprecate LogConfig.Compact
Date Sun, 20 Aug 2017 06:54:46 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 6896f1ddb -> 26c65953e


MINOR: Deprecate LogConfig.Compact

It actually refers to the `delete` cleanup policy.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Jason Gustafson <jason@confluent.io>

Closes #3634 from ijuma/fix-misleading-compact-log-config


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/26c65953
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/26c65953
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/26c65953

Branch: refs/heads/trunk
Commit: 26c65953ede2b449d7165f2d04453bc00dd29c20
Parents: 6896f1d
Author: Ismael Juma <ismael@juma.me.uk>
Authored: Sun Aug 20 07:54:36 2017 +0100
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Sun Aug 20 07:54:36 2017 +0100

----------------------------------------------------------------------
 core/src/main/scala/kafka/log/LogConfig.scala | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/26c65953/core/src/main/scala/kafka/log/LogConfig.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/log/LogConfig.scala b/core/src/main/scala/kafka/log/LogConfig.scala
index c47d229..b515c5d 100755
--- a/core/src/main/scala/kafka/log/LogConfig.scala
+++ b/core/src/main/scala/kafka/log/LogConfig.scala
@@ -47,7 +47,11 @@ object Defaults {
   val DeleteRetentionMs = kafka.server.Defaults.LogCleanerDeleteRetentionMs
   val MinCompactionLagMs = kafka.server.Defaults.LogCleanerMinCompactionLagMs
   val MinCleanableDirtyRatio = kafka.server.Defaults.LogCleanerMinCleanRatio
+
+  @deprecated(message = "This is a misleading variable name as it actually refers to the
'delete' cleanup policy. Use " +
+                        "`CleanupPolicy` instead.", since = "1.0.0")
   val Compact = kafka.server.Defaults.LogCleanupPolicy
+  
   val CleanupPolicy = kafka.server.Defaults.LogCleanupPolicy
   val UncleanLeaderElectionEnable = kafka.server.Defaults.UncleanLeaderElectionEnable
   val MinInSyncReplicas = kafka.server.Defaults.MinInSyncReplicas


Mime
View raw message