kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From damian...@apache.org
Subject kafka git commit: KAFKA-5549; Explain that 'client.id' is just used as a prefix within Streams
Date Thu, 27 Jul 2017 15:00:57 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 8b14e1174 -> 9d6020ec5


KAFKA-5549; Explain that 'client.id' is just used as a prefix within Streams

- Added new String CLIENT_ID_DOC in StreamsConfig for explanation

Author: Pranav Maniar <pranav9428@gmail.com>

Reviewers: Matthias J. Sax <matthias@confluent.io>, Damian Guy <damian.guy@gmail.com>

Closes #3544 from PranavManiar/trunk


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/9d6020ec
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/9d6020ec
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/9d6020ec

Branch: refs/heads/trunk
Commit: 9d6020ec5fac21f36e2caa58256ee2158658866e
Parents: 8b14e11
Author: Pranav Maniar <pranav9428@gmail.com>
Authored: Thu Jul 27 16:00:51 2017 +0100
Committer: Damian Guy <damian.guy@gmail.com>
Committed: Thu Jul 27 16:00:51 2017 +0100

----------------------------------------------------------------------
 .../src/main/java/org/apache/kafka/streams/StreamsConfig.java    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/9d6020ec/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
----------------------------------------------------------------------
diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
index e4869ee..c2e1077 100644
--- a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
+++ b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
@@ -146,6 +146,8 @@ public class StreamsConfig extends AbstractConfig {
 
     /** {@code client.id} */
     public static final String CLIENT_ID_CONFIG = CommonClientConfigs.CLIENT_ID_CONFIG;
+    private static final String CLIENT_ID_DOC = "An ID prefix string used for the client
IDs of internal consumer, producer and restore-consumer," +
+        " with pattern '<client.id>-StreamThread-<threadSequenceNumber>-<consumer|producer|restore-consumer>'.";
 
     /** {@code commit.interval.ms} */
     public static final String COMMIT_INTERVAL_MS_CONFIG = "commit.interval.ms";
@@ -319,7 +321,7 @@ public class StreamsConfig extends AbstractConfig {
                     Type.STRING,
                     "",
                     Importance.MEDIUM,
-                    CommonClientConfigs.CLIENT_ID_DOC)
+                    CLIENT_ID_DOC)
             .define(DEFAULT_DESERIALIZATION_EXCEPTION_HANDLER_CLASS_CONFIG,
                 Type.CLASS,
                 LogAndFailExceptionHandler.class.getName(),


Mime
View raw message