kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: MINOR: Adjust checkstyle suppression paths to work on Windows
Date Wed, 28 Jun 2017 00:48:06 GMT
Repository: kafka
Updated Branches:
  refs/heads/0.11.0 dd006c82c -> ec5b22c8b


MINOR: Adjust checkstyle suppression paths to work on Windows

Use the file name whenever possible and replace / with [/\\]
when it's not.

Also remove unnecessary suppresions.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Vahid Hashemian <vahidhashemian@us.ibm.com>, Jason Gustafson <jason@confluent.io>

Closes #3431 from ijuma/fix-checkstyle-suppressions-on-windows

(cherry picked from commit a293e1dc0c0cdc6620abb3c8e099f29772e3d688)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/ec5b22c8
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/ec5b22c8
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/ec5b22c8

Branch: refs/heads/0.11.0
Commit: ec5b22c8b7e5cc6a272235c2c2c11d98c980536f
Parents: dd006c8
Author: Ismael Juma <ismael@juma.me.uk>
Authored: Wed Jun 28 01:47:00 2017 +0100
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Wed Jun 28 01:47:24 2017 +0100

----------------------------------------------------------------------
 checkstyle/suppressions.xml | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/ec5b22c8/checkstyle/suppressions.xml
----------------------------------------------------------------------
diff --git a/checkstyle/suppressions.xml b/checkstyle/suppressions.xml
index f2fb3d9..7f98820 100644
--- a/checkstyle/suppressions.xml
+++ b/checkstyle/suppressions.xml
@@ -6,17 +6,19 @@
 
 <suppressions>
 
+    <!-- Note that [/\\] must be used as the path separator for cross-platform support
-->
+
     <!-- Clients -->
     <suppress checks="ClassFanOutComplexity"
               files="(Fetcher|Sender|SenderTest|ConsumerCoordinator|KafkaConsumer|KafkaProducer|SaslServerAuthenticator|Utils|TransactionManagerTest|KafkaAdminClient|NetworkClient).java"/>
     <suppress checks="ClassFanOutComplexity"
-              files=".*/protocol/Errors.java"/>
+              files="Errors.java"/>
     <suppress checks="ClassFanOutComplexity"
-              files=".*/common/utils/Utils.java"/>
+              files="Utils.java"/>
     <suppress checks="ClassFanOutComplexity"
-              files=".*/requests/AbstractRequest.java"/>
+              files="AbstractRequest.java"/>
     <suppress checks="ClassFanOutComplexity"
-              files=".*/requests/AbstractResponse.java"/>
+              files="AbstractResponse.java"/>
 
     <suppress checks="MethodLength"
               files="KerberosLogin.java|RequestResponseTest.java"/>
@@ -37,13 +39,13 @@
     <suppress checks="ClassDataAbstractionCoupling"
               files="(KafkaConsumer|ConsumerCoordinator|Fetcher|KafkaProducer|AbstractRequest|AbstractResponse|TransactionManager|KafkaAdminClient).java"/>
     <suppress checks="ClassDataAbstractionCoupling"
-              files=".*/protocol/Errors.java"/>
+              files="Errors.java"/>
 
     <suppress checks="BooleanExpressionComplexity"
               files="(Utils|KafkaLZ4BlockOutputStream|AclData).java"/>
 
     <suppress checks="CyclomaticComplexity"
-              files="(ConsumerCoordinator|Fetcher|Sender|KafkaProducer|BufferPool|ConfigDef|RecordAccumulator|SsLTransportLayer|KerberosLogin|AbstractRequest|AbstractResponse|Selector|SslTransportLayer).java"/>
+              files="(ConsumerCoordinator|Fetcher|Sender|KafkaProducer|BufferPool|ConfigDef|RecordAccumulator|KerberosLogin|AbstractRequest|AbstractResponse|Selector|SslTransportLayer).java"/>
 
     <suppress checks="JavaNCSS"
               files="AbstractRequest.java|KerberosLogin.java"/>
@@ -157,9 +159,7 @@
               files="KStreamWindowAggregateTest.java"/>
 
     <suppress checks="ClassDataAbstractionCoupling"
-              files=".*/streams/.*/Test.java"/>
-    <suppress checks="ClassDataAbstractionCoupling"
-              files=".*/streams/.*test/.*.java"/>
+              files=".*[/\\]streams[/\\].*test[/\\].*.java"/>
 
     <suppress checks="BooleanExpressionComplexity"
               files="SmokeTestDriver.java"/>


Mime
View raw message