kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: MINOR: Use new-consumer config in MirrorMaker doc
Date Wed, 17 May 2017 11:36:42 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 1cea4d8f5 -> 62d5aac5d


MINOR: Use new-consumer config in MirrorMaker doc

Mirrormaker was updated to default to the new consumer in 3db752a565071c78e4b11eaafa739844fa785b04

Old consumer calls the param `auto.commit.enable`, new consumer calls it `enable.auto.commit`.
So I updated the docstring to use the new consumer name for the param.

Author: Jeff Widman <jeff@jeffwidman.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #2393 from jeffwidman/patch-1


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/62d5aac5
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/62d5aac5
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/62d5aac5

Branch: refs/heads/trunk
Commit: 62d5aac5dda5ad7108aeb41ac3006221e2dab74b
Parents: 1cea4d8
Author: Jeff Widman <jeff@jeffwidman.com>
Authored: Wed May 17 12:36:38 2017 +0100
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Wed May 17 12:36:38 2017 +0100

----------------------------------------------------------------------
 core/src/main/scala/kafka/tools/MirrorMaker.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/62d5aac5/core/src/main/scala/kafka/tools/MirrorMaker.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/tools/MirrorMaker.scala b/core/src/main/scala/kafka/tools/MirrorMaker.scala
index b3a7978..d61b355 100755
--- a/core/src/main/scala/kafka/tools/MirrorMaker.scala
+++ b/core/src/main/scala/kafka/tools/MirrorMaker.scala
@@ -59,7 +59,7 @@ import org.apache.kafka.common.record.RecordBatch
  *            max.block.ms=max long
  *            max.in.flight.requests.per.connection=1
  *       2. Consumer Settings
- *            auto.commit.enable=false
+ *            enable.auto.commit=false
  *       3. Mirror Maker Setting:
  *            abort.on.send.failure=true
  */


Mime
View raw message