kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: MINOR: Log error if offsets topic creation fails
Date Fri, 17 Mar 2017 10:26:46 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk cfda0368d -> c5adf17ae


MINOR: Log error if offsets topic creation fails

This problem is hard to debug otherwise as there error
returned to the client (“Coordinator not available”) is not
very informative.

Author: Eno Thereska <eno.thereska@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #2652 from enothereska/minor-warning-enforcement-offset


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/c5adf17a
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/c5adf17a
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/c5adf17a

Branch: refs/heads/trunk
Commit: c5adf17aeae763d9e8a4e802d988a464fef5d5e8
Parents: cfda036
Author: Eno Thereska <eno@confluent.io>
Authored: Fri Mar 17 09:57:03 2017 +0000
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Fri Mar 17 10:26:28 2017 +0000

----------------------------------------------------------------------
 core/src/main/scala/kafka/server/KafkaApis.scala | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/c5adf17a/core/src/main/scala/kafka/server/KafkaApis.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/server/KafkaApis.scala b/core/src/main/scala/kafka/server/KafkaApis.scala
index fbc0840..d2f8dba 100644
--- a/core/src/main/scala/kafka/server/KafkaApis.scala
+++ b/core/src/main/scala/kafka/server/KafkaApis.scala
@@ -776,6 +776,10 @@ class KafkaApis(val requestChannel: RequestChannel,
   private def createGroupMetadataTopic(): MetadataResponse.TopicMetadata = {
     val aliveBrokers = metadataCache.getAliveBrokers
     if (aliveBrokers.size < config.offsetsTopicReplicationFactor) {
+      error(s"Number of alive brokers '${aliveBrokers.size}' does not meet the required replication
factor " +
+        s"'${config.offsetsTopicReplicationFactor}' for the offsets topic (configured via
" +
+        s"'${KafkaConfig.OffsetsTopicReplicationFactorProp}'). This error can be ignored
if the cluster is starting up " +
+        s"and not all brokers are up yet.")
       new MetadataResponse.TopicMetadata(Errors.GROUP_COORDINATOR_NOT_AVAILABLE, Topic.GroupMetadataTopicName,
true,
         java.util.Collections.emptyList())
     } else {


Mime
View raw message