kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: MINOR: Increase Throttle lower bound assertion in throttling_test
Date Fri, 17 Mar 2017 12:40:26 GMT
Repository: kafka
Updated Branches:
  refs/heads/0.10.2 94938f373 -> 4a019bdfa


MINOR: Increase Throttle lower bound assertion in throttling_test

Improves the reliability of this test by decreasing the lower bound (this is to be expected
as throttling  takes the first fetch to stabilise and will "over-fetch" for this first request)

Author: Ben Stopford <benstopford@gmail.com>

Reviewers: Apurva Mehta <apurva@confluent.io>, Ismael Juma <ismael@juma.me.uk>

Closes #2698 from benstopford/throttling-test-fix

(cherry picked from commit 6b11fb7af81390789ba449c0cd5daa81c8ee9cb5)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/4a019bdf
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/4a019bdf
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/4a019bdf

Branch: refs/heads/0.10.2
Commit: 4a019bdfaf2ab7110660b313df5bb05ab195e614
Parents: 94938f3
Author: Ben Stopford <benstopford@gmail.com>
Authored: Fri Mar 17 12:39:53 2017 +0000
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Fri Mar 17 12:40:22 2017 +0000

----------------------------------------------------------------------
 tests/kafkatest/tests/core/throttling_test.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/4a019bdf/tests/kafkatest/tests/core/throttling_test.py
----------------------------------------------------------------------
diff --git a/tests/kafkatest/tests/core/throttling_test.py b/tests/kafkatest/tests/core/throttling_test.py
index a80af39..94a4010 100644
--- a/tests/kafkatest/tests/core/throttling_test.py
+++ b/tests/kafkatest/tests/core/throttling_test.py
@@ -133,7 +133,7 @@ class ThrottlingTest(ProduceConsumeValidateTest):
         self.logger.debug("Transfer took %d second. Estimated time : %ds",
                           time_taken,
                           estimated_throttled_time)
-        assert time_taken >= estimated_throttled_time, \
+        assert time_taken >= estimated_throttled_time * 0.9, \
             ("Expected rebalance to take at least %ds, but it took %ds" % (
                 estimated_throttled_time,
                 time_taken))


Mime
View raw message