kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject kafka git commit: MINOR: Update possible errors in OffsetFetchResponse
Date Thu, 30 Mar 2017 18:25:03 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 4b3ea062b -> 2e075fe6a


MINOR: Update possible errors in OffsetFetchResponse

Note: None of the use cases for offset fetch would lead to a `TOPIC_AUTHORIZATION_FAILED`
error (fetching offset of an unauthorized partition would return an `UNKNOWN_TOPIC_OR_PARTITION`
error). That is why it is being removed from the `PARTITION_ERRORS` list.

Author: Vahid Hashemian <vahidhashemian@us.ibm.com>

Reviewers: Jason Gustafson <jason@confluent.io>

Closes #2653 from vahidhashemian/minor/update_possible_errors_in_offset_fetch_response


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/2e075fe6
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/2e075fe6
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/2e075fe6

Branch: refs/heads/trunk
Commit: 2e075fe6a47221b24abc49c25a4a69a447362eeb
Parents: 4b3ea06
Author: Vahid Hashemian <vahidhashemian@us.ibm.com>
Authored: Thu Mar 30 11:24:01 2017 -0700
Committer: Jason Gustafson <jason@confluent.io>
Committed: Thu Mar 30 11:24:01 2017 -0700

----------------------------------------------------------------------
 .../org/apache/kafka/common/requests/OffsetFetchResponse.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/2e075fe6/clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
b/clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
index 5e69beb..b16b233 100644
--- a/clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
+++ b/clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
@@ -57,13 +57,13 @@ public class OffsetFetchResponse extends AbstractResponse {
      *
      * - Group or coordinator errors:
      *   - GROUP_LOAD_IN_PROGRESS (14)
+     *   - GROUP_COORDINATOR_NOT_AVAILABLE (15)
      *   - NOT_COORDINATOR_FOR_GROUP (16)
      *   - GROUP_AUTHORIZATION_FAILED (30)
      */
 
     private static final List<Errors> PARTITION_ERRORS = Arrays.asList(
-            Errors.UNKNOWN_TOPIC_OR_PARTITION,
-            Errors.TOPIC_AUTHORIZATION_FAILED);
+            Errors.UNKNOWN_TOPIC_OR_PARTITION);
 
     private final Map<TopicPartition, PartitionData> responseData;
     private final Errors error;


Mime
View raw message